Issue 341970043: [dfvfs] Added recursive hasher end-to-end test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 341970043: [dfvfs] Added recursive hasher end-to-end test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
6 years ago

Reviewers:
romaing

CC:
kiddi, log2timeline-dev_googlegroups.com, onager

Visibility:
Public.

More Reviews

Description

[dfvfs] Added recursive hasher end-to-end test

Patch Set 1 : Added recursive hasher end-to-end test #

Patch Set 2 : Added recursive hasher end-to-end test #

Total comments: 2

Patch Set 3 : Changes after review #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+946 lines, -75 lines)			Patch
M	.travis.yml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	appveyor.yml	View		1 chunk	+10 lines, -3 lines	0 comments	Download
A	config/end-to-end.ini	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	config/travis/run_with_timeout.sh	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	config/travis/runtests.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	examples/recursive_hasher.py	View	1 2	13 chunks	+131 lines, -55 lines	0 comments	Download
M	setup.py	View		2 chunks	+10 lines, -13 lines	0 comments	Download
A	test_data/end_to_end/image.qcow2.hashes	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/end-to-end.py	View		1 chunk	+739 lines, -0 lines	0 comments	Download
M	utils/dependencies.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

romaing

LGTM Just one nit/question https://codereview.appspot.com/341970043/diff/40001/examples/recursive_hasher.py File examples/recursive_hasher.py (right): https://codereview.appspot.com/341970043/diff/40001/examples/recursive_hasher.py#newcode536 examples/recursive_hasher.py:536: return True Silly question: should ...

6 years ago (2018-04-11 12:19:27 UTC) #4

Joachim Metz

https://codereview.appspot.com/341970043/diff/40001/examples/recursive_hasher.py File examples/recursive_hasher.py (right): https://codereview.appspot.com/341970043/diff/40001/examples/recursive_hasher.py#newcode536 examples/recursive_hasher.py:536: return True good question, I can remove it does ...

6 years ago (2018-04-11 19:21:25 UTC) #5

Joachim Metz

6 years ago (2018-04-11 19:26:19 UTC) #7

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close end2end

Expand All Messages | Collapse All Messages