Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(5680)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
341890043
: WIP
Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by
ajuma
Modified:
6 years ago
Reviewers:
Visibility:
Public.
More Reviews
Description
WIP Patch BUG=
Patch Set 1
#
Patch Set 2 : shows a warning
#
Patch Set 3 : Fixes and logging
#
Patch Set 4 : IFrames work, at least on non-Safari.
#
Patch Set 5 : WIP
#
Patch Set 6 : Cleanup
#
Patch Set 7 : Current patch
#
Patch Set 8 : Fix up
#
Created:
6 years ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+134 lines, -30 lines
)
Patch
M
Source/WebCore/loader/DocumentLoader.cpp
View
1
2
3
4
5
6
2 chunks
+5 lines, -1 line
0 comments
Download
M
Source/WebCore/loader/FrameLoader.h
View
1
2
3
1 chunk
+1 line, -1 line
0 comments
Download
M
Source/WebCore/loader/FrameLoader.cpp
View
1
2
3
4
5
6
7
9 chunks
+14 lines, -9 lines
0 comments
Download
M
Source/WebCore/loader/FrameLoaderTypes.h
View
1
2
3
2 chunks
+3 lines, -1 line
0 comments
Download
M
Source/WebCore/loader/PolicyChecker.h
View
1
1 chunk
+2 lines, -1 line
0 comments
Download
M
Source/WebCore/loader/PolicyChecker.cpp
View
1
2
3
4
5
6
6 chunks
+19 lines, -10 lines
0 comments
Download
M
Source/WebCore/page/SecurityOrigin.h
View
1
2
3
4
5
6
1 chunk
+1 line, -0 lines
0 comments
Download
M
Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp
View
1
2
1 chunk
+3 lines, -0 lines
0 comments
Download
M
Source/WebKit/NetworkProcess/capture/NetworkDataTaskReplay.cpp
View
1
2
1 chunk
+3 lines, -0 lines
0 comments
Download
M
Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
View
1
2
3
4
5
6
1 chunk
+3 lines, -0 lines
0 comments
Download
M
Source/WebKit/UIProcess/Cocoa/NavigationState.mm
View
1
2
3
4
5
5 chunks
+69 lines, -7 lines
0 comments
Download
M
Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h
View
1
2
1 chunk
+1 line, -0 lines
0 comments
Download
M
Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp
View
1
2
1 chunk
+5 lines, -0 lines
0 comments
Download
M
Source/WebKit/UIProcess/WebPageProxy.cpp
View
1
2
3
4
5
6
7
1 chunk
+1 line, -0 lines
0 comments
Download
M
Source/WebKit/WebProcess/WebPage/WebPage.cpp
View
1
2
3
4
5
6
2 chunks
+2 lines, -0 lines
0 comments
Download
M
Tools/MiniBrowser/MiniBrowser.entitlements
View
1
2
3
4
5
6
1 chunk
+2 lines, -0 lines
0 comments
Download
Issue 341890043: WIP
Created 6 years, 1 month ago by ajuma
Modified 6 years ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
