Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1080)

Issue 341490043: First separator for subassignments must be '.'

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by dak
Modified:
2 months, 1 week ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

First separator for subassignments must be '.' This pares down syntax supported since issue 4790 to match the allowed usage from issue 4797. Permitting ',' here seemed particularly strange.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M lily/parser.yy View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3
thomasmorley651
Even without your patch one can do: part.1,1 = "foo" part.1,2 = "bar" part.1,3 = ...
2 months, 1 week ago (2018-10-03 16:56:27 UTC) #1
dak
On 2018/10/03 16:56:27, thomasmorley651 wrote: > Even without your patch one can do: > > ...
2 months, 1 week ago (2018-10-03 17:19:45 UTC) #2
dak
2 months, 1 week ago (2018-10-03 17:27:43 UTC) #3
On 2018/10/03 16:56:27, thomasmorley651 wrote:
> Even without your patch one can do:

Oh, I forgot: "even without your patch" points to a misunderstanding.  The sole
purpose of this patch is to remove a previously accepted construct for
assignment because, well, I was troubled by a discussion pointing out that it
was accepted (though only in assignment, not in reference).

It doesn't seem either practically nor conceptually useful, there was no
discussion when I implemented it as part of another patch, and it seems like a
mistake to me now that I did so.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b