Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(103)

Issue 341470043: issue 3692: Fingering collision with accidentals

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Be-3
Modified:
2 months, 1 week ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

issue 3692: Fingering collision with accidentals Changes to be committed: modified: ../Documentation/changes.tely - Announcing the new X-align-on-main-noteheads feature for the New_fingering_engraver new file: ../input/regression/fingering-adjacent-note-chord-new.ly new file: ../input/regression/fingering-adjacent-note-chord.ly - Adjacent-note chord regression tests for New_fingering_engraver and Fingering_engraver. modified: ../lily/fingering-engraver.cc - Instead of aligning the fingering on the first-to-come notehead of the chord, now use note-column as parent and take advantage of the side-position-interface's X-align-on-main-noteheads functionality. - The (sometimes) incorrect alignment caused by simply using the the first chord note entered as parent was, after all, the actual reason for the accidental collision that never had happened with a proper fingering alignment. modified: ../lily/new-fingering-engraver.cc - Making New_fingering_engraver consider the X-align-on-main-noteheads property and use note-column as parent for up/down orientations. That way, up/down fingerings will be aligned in a straight column, properly centered over the main noteheads. - With "classic" per-note alignment, use notehead as parent (as it had been always done), but now avoid all accidentals in the chord for up/down placement. - If there's only one note, no special alignment/accidental treatment needed. - accidentals_.clear () had been missing after position_all (), so that more and more accidentals gathered up from chord to chord. - By default, X-align-on-main-noteheads is *not* set to keep everything compatible to the previous practice. - When setting X-align-on-main-noteheads and using just up/down orientation, New_fingering_engraver behaves like Fingering_engraver.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -6 lines) Patch
M Documentation/changes.tely View 1 chunk +21 lines, -0 lines 0 comments Download
A input/regression/fingering-adjacent-note-chord.ly View 1 chunk +21 lines, -0 lines 0 comments Download
A input/regression/fingering-adjacent-note-chord-new.ly View 1 chunk +38 lines, -0 lines 0 comments Download
M lily/fingering-engraver.cc View 4 chunks +13 lines, -4 lines 0 comments Download
M lily/new-fingering-engraver.cc View 7 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 1
Be-3
2 months, 1 week ago (2018-09-08 14:11:44 UTC) #1
Please review.

Thanks,
Torsten
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b