Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 341350043: issue #5341: Urgent corrections to stencil-integral.cc (skylines)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Be-3
Modified:
2 months, 1 week ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

issue #5341: Urgent corrections to stencil-integral.cc (skylines) modified: ../lily/stencil-integral.cc Main correction: Stencil::skylines_from_stencil Avoid garbage collection by introducing an SCM variable new_s. Minor changes: make_round_filled_boxes line 393: increasing step width in order to skip unneccessary straight lines. line 432: replacing a < by a clearer <=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rotation coding temporarily deactivated as discussed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M lily/stencil-integral.cc View 1 4 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 6
Be-3
Please review (ideally DAK) Thanks, Torsten
2 months, 1 week ago (2018-06-11 17:20:47 UTC) #1
dak
https://codereview.appspot.com/341350043/diff/1/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/341350043/diff/1/lily/stencil-integral.cc#newcode1132 lily/stencil-integral.cc:1132: SCM new_s = s->smobbed_copy (); This does not work: ...
2 months, 1 week ago (2018-06-12 10:05:17 UTC) #2
Be-3
On 2018/06/12 10:05:17, dak wrote: > However, cough cough, all this is an unnecessary complication. ...
2 months, 1 week ago (2018-06-12 10:49:11 UTC) #3
dak
On 2018/06/12 10:49:11, Be-3 wrote: > On 2018/06/12 10:05:17, dak wrote: > > However, cough ...
2 months, 1 week ago (2018-06-12 11:40:56 UTC) #4
dak
On 2018/06/12 10:49:11, Be-3 wrote: > On 2018/06/12 10:05:17, dak wrote: > > However, cough ...
2 months, 1 week ago (2018-06-12 11:47:07 UTC) #5
Be-3
2 months, 1 week ago (2018-06-12 14:30:26 UTC) #6
Rotation coding temporarily deactivated as discussed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b