Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1288)

Issue 34130043: Deploy the GUI to machine 0 in functional tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by frankban
Modified:
6 years, 4 months ago
Reviewers:
mp+196954, matthew.scott, gary.poster
Visibility:
Public.

Description

Deploy the GUI to machine 0 in functional tests. Also added guiserver info checks, and fixed the deploy module so that the previous behavior of "make deploy" is restored and the resulting service name is not random generated. Removed test_local_release: that scenario is already tested in TestBuiltinServerLocalRelease. Moved test_nrpe_check_available to TestBuiltinServerLocalRelease. Tests: assuming ec2 is the name of your ec2 environment, run the following: `time make ftest JUJU_ENV="ec2"` Tests should pass and take ~25-30 minutes. https://code.launchpad.net/~frankban/charms/precise/juju-gui/ftests-bootstrap-node/+merge/196954 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Deploy the GUI to machine 0 in functional tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -108 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M server/guiserver/tests/test_auth.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/20-functional.test View 11 chunks +90 lines, -72 lines 0 comments Download
M tests/deploy.py View 2 chunks +19 lines, -18 lines 0 comments Download
M tests/example.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/helpers.py View 2 chunks +9 lines, -0 lines 0 comments Download
M tests/test_deploy.py View 4 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
6 years, 4 months ago (2013-11-27 17:39:36 UTC) #1
gary.poster
LGTM with trivial. Thank you! https://codereview.appspot.com/34130043/diff/1/tests/20-functional.test File tests/20-functional.test (right): https://codereview.appspot.com/34130043/diff/1/tests/20-functional.test#newcode58 tests/20-functional.test:58: Deploy the charm in ...
6 years, 4 months ago (2013-11-27 17:57:08 UTC) #2
matthew.scott
Code LGTMly, was not able to QA due to unrelated failures; can someone else QA ...
6 years, 4 months ago (2013-11-28 03:23:02 UTC) #3
jeff.pihach
QA OK real 23m39.657s
6 years, 4 months ago (2013-11-28 16:16:25 UTC) #4
frankban
*** Submitted: Deploy the GUI to machine 0 in functional tests. Also added guiserver info ...
6 years, 4 months ago (2013-11-28 17:58:38 UTC) #5
frankban
6 years, 4 months ago (2013-11-28 18:08:10 UTC) #6
Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b