Displays the relation name for peer relations

Displays the relation name for peer relations



https://code.launchpad.net/~hatch/juju-gui/peer-status-1255336/+merge/196964

(do not edit description out of merge proposal)

[jeff.pihach, 2013-11-27 19:01:26]

Please take a look.

[benji, 2013-11-27 19:05:40]

This looks fine.  They do need tests.

LGTM

https://codereview.appspot.com/34120044/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/34120044/diff/1/app/views/utils.js#newcode1693
app/views/utils.js:1693: if (!relation.far) { // It's a peer relation
It would be a little clearer if the negation was removed from the condition and
the then/else clauses were swapped.

https://codereview.appspot.com/34120044/diff/1/app/views/utils.js#newcode1707
app/views/utils.js:1707: return relation.far.service;
I'm not too hung up on it, but the above code is duplicated from above.  Maybe
there is a nice way to factor both copies into a third place.

[jeff.pihach, 2013-11-27 19:12:59]

Thanks for the review - Changes made and tests will be submitted.

https://codereview.appspot.com/34120044/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/34120044/diff/1/app/views/utils.js#newcode1693
app/views/utils.js:1693: if (!relation.far) { // It's a peer relation
On 2013/11/27 19:05:40, benji wrote:
> It would be a little clearer if the negation was removed from the condition
and
> the then/else clauses were swapped.

Done.

[jeff.pihach, 2013-11-27 19:32:19]

*** Submitted:

Displays the relation name for peer relations

R=benji
CC=
https://codereview.appspot.com/34120044