Issue 341160043: [dfdatetime] Changed __eq__ and __ne__ not to raise ValueError

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 341160043: [dfdatetime] Changed eq and ne not to raise ValueError (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
5 years, 12 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

[dfdatetime] Changed __eq__ and __ne__ not to raise ValueError These changes allow a dfdatetime object to be compared to None.

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -44 lines)			Patch
M	dfdatetime/interface.py	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	dfdatetime/semantic_time.py	View	4 chunks	+0 lines, -24 lines	0 comments	Download
M	tests/interface.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/semantic_time.py	View	4 chunks	+4 lines, -8 lines	0 comments	Download

Total messages: 3

Joachim Metz

5 years, 12 months ago (2018-05-01 15:49:09 UTC) #3

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close cmp