Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(352)

Issue 341140043: issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 4 weeks ago by Be-3
Modified:
4 months, 1 week ago
Reviewers:
dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses) lily/stencil-integral.cc function make_partial_ellipse_boxes: Use correct scaling factors for x_rad and y_rad for an arbitrary transformation matrix This affects calculation of quantisation value function make_round_filled_box_boxes: (1) remove unintentional additional space between box and skyline (2) In case of rounded corners (threshold: diameter > 0.5 staff spaces) or rotation, a detailed skyline will be constructed. Rotated straight lines are drawn using buildings. Rounded corners built out of boxes (cf. ellipse). (3) Draw simple single-box skyline for simple boxes (i.e. in most cases, e.g. ledger lines).

Patch Set 1 #

Total comments: 1

Patch Set 2 : Wrap lines, consistent quantization/radius #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -13 lines) Patch
M Documentation/changes.tely View 1 chunk +13 lines, -0 lines 0 comments Download
A input/regression/skyline-boxes-ellipses.ly View 1 chunk +39 lines, -0 lines 0 comments Download
M lily/stencil-integral.cc View 1 4 chunks +99 lines, -13 lines 2 comments Download

Messages

Total messages: 5
Be-3
Please review... Thanks Torsten
5 months, 4 weeks ago (2018-04-20 22:52:53 UTC) #1
lemzwerg
LGTM, thanks! https://codereview.appspot.com/341140043/diff/1/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/341140043/diff/1/lily/stencil-integral.cc#newcode410 lily/stencil-integral.cc:410: int quantization = max (0, (int) (rounded ...
5 months, 4 weeks ago (2018-04-21 04:38:38 UTC) #2
Be-3
Wrap lines, consistent quantization/radius
5 months, 3 weeks ago (2018-04-21 10:23:52 UTC) #3
Be-3
> lily/stencil-integral.cc:410: int quantization = max (0, (int) (rounded * > (x_scale + y_scale) * ...
5 months, 3 weeks ago (2018-04-21 10:26:16 UTC) #4
dak
4 months, 1 week ago (2018-06-09 20:56:34 UTC) #5
https://codereview.appspot.com/341140043/diff/20001/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):

https://codereview.appspot.com/341140043/diff/20001/lily/stencil-integral.cc#...
lily/stencil-integral.cc:393: for (vsize i = 0; i < (vsize) points.size () - 1;
i++)
Why would the last point not be transformed?

https://codereview.appspot.com/341140043/diff/20001/lily/stencil-integral.cc#...
lily/stencil-integral.cc:423: for (vsize i = 0; i < (vsize) quantization + 1;
i++)
Why not i <= quantization ?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b