Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2654)

Issue 341020043: [l2tdevtools] Refactored TravisInstallScriptWriter to use template file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by Joachim Metz
Modified:
6 years ago
Reviewers:
jberggren
CC:
kiddi, log2timeline-dev_googlegroups.com, onager
Visibility:
Public.

Description

[l2tdevtools] Refactored TravisInstallScriptWriter to use template file Depends on: https://codereview.appspot.com/340630043/

Patch Set 1 #

Patch Set 2 : Refactored TravisInstallScriptWriter to use template file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -108 lines) Patch
A data/templates/install.sh View 1 chunk +62 lines, -0 lines 0 comments Download
M l2tdevtools/dependency_writers/travis.py View 1 chunk +27 lines, -108 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
6 years ago (2018-04-02 06:38:37 UTC) #1
jberggren
On 2018/04/02 06:38:37, Joachim Metz wrote: LGTM
6 years ago (2018-04-05 08:23:47 UTC) #2
Joachim Metz
Code updated.
6 years ago (2018-04-05 20:55:02 UTC) #3
Joachim Metz
6 years ago (2018-04-05 20:56:20 UTC) #4
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close deptools3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b