Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1131)

Issue 340660043: Issue 3128: add Haydn-style turns to Feta

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by Malte Meyn
Modified:
5 months, 1 week ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3128: add Haydn-style turns to Feta This adds two variants of a turn with a vertical slash: scripts.slashturn (SMuFL U+E569) and scripts.haydnturn (SMuFL U+E56F) Also, scripts \slashturn and \haydnturn are added. I’ll attach a PDF showing them being used to the sourceforge issue.

Patch Set 1 #

Total comments: 3

Patch Set 2 : improve code style #

Patch Set 3 : add the turns to script-chart.ly (only used by the German NR), add the turns to NR and Changes #

Patch Set 4 : make slashturn 4% thinner at the center (instead of 10% thicker), haydnturn 0% thicker (instead of … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -60 lines) Patch
M Documentation/changes.tely View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M Documentation/included/script-chart.ly View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Documentation/notation/expressive.itely View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M Documentation/notation/notation-appendices.itely View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M ly/script-init.ly View 2 chunks +2 lines, -0 lines 0 comments Download
M mf/feta-scripts.mf View 1 2 3 5 chunks +79 lines, -7 lines 0 comments Download
M ps/encodingdefs.ps View 2 chunks +55 lines, -53 lines 0 comments Download
M scm/script.scm View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13
lemzwerg
Very nice! LGTM. https://codereview.appspot.com/340660043/diff/1/mf/feta-scripts.mf File mf/feta-scripts.mf (right): https://codereview.appspot.com/340660043/diff/1/mf/feta-scripts.mf#newcode757 mf/feta-scripts.mf:757: set_char_box (wd# / 2, wd# / ...
5 months, 2 weeks ago (2018-04-08 14:17:21 UTC) #1
Malte Meyn
improve code style
5 months, 2 weeks ago (2018-04-08 14:22:16 UTC) #2
Malte Meyn
add the turns to script-chart.ly (only used by the German NR), add the turns to ...
5 months, 2 weeks ago (2018-04-08 16:31:53 UTC) #3
Dan Eble
Is there a performance difference between these two scripts? I read quickly through the thread ...
5 months, 2 weeks ago (2018-04-08 17:08:42 UTC) #4
simon.albrecht
On 08.04.2018 19:08, nine.fierce.ballads@gmail.com wrote: > Is there a performance difference between these two scripts? ...
5 months, 2 weeks ago (2018-04-08 17:43:36 UTC) #5
Malte Meyn
On 2018/04/08 17:08:42, Dan Eble wrote: > Is there a performance difference between these two ...
5 months, 2 weeks ago (2018-04-08 17:55:03 UTC) #6
Dan Eble
On 2018/04/08 17:43:36, simon.albrecht wrote: > I’m not sure what exactly the difference in performing ...
5 months, 2 weeks ago (2018-04-08 18:05:49 UTC) #7
Malte Meyn
On 2018/04/08 18:05:49, Dan Eble wrote: > Having two symbols available does not necessarily require ...
5 months, 2 weeks ago (2018-04-09 07:42:12 UTC) #8
Lukas-Fabian Moser
This is gorgeous! Thanks very much! Is the \haydnturn supposed to be symmetrical w.r.t. the ...
5 months, 1 week ago (2018-04-10 09:47:31 UTC) #9
Malte Meyn
On 2018/04/10 09:47:31, Lukas-Fabian Moser wrote: > This is gorgeous! Thanks very much! > > ...
5 months, 1 week ago (2018-04-10 17:20:17 UTC) #10
Malte Meyn
make slashturn 4% thinner at the center (instead of 10% thicker), haydnturn 0% thicker (instead ...
5 months, 1 week ago (2018-04-10 17:21:43 UTC) #11
Malte Meyn
On 2018/04/10 17:21:43, Malte Meyn wrote: > make slashturn 4% thinner at the center (instead ...
5 months, 1 week ago (2018-04-10 17:29:48 UTC) #12
Lukas-Fabian Moser
5 months, 1 week ago (2018-04-10 21:53:23 UTC) #13
> On 2018/04/10 17:21:43, Malte Meyn wrote:
> > make slashturn 4% thinner at the center (instead of 10% thicker)
> 
> IMHO that’s an improvement.

Yes, I agree.

> > haydnturn 0%
> > thicker (instead of 10% thicker)
> 
> I’m not sure whether this is, the glyph shouldn’t be too slim to match the
> overall style of the Feta font.

You're probably right.
I am a little confused as to my eye-sight - even after I checked that the glyph
is completely symmetric, I "feel" that the \haydnturn's right part is "steeper".
At one point I thought it might be an optical illusion triggered by the note
head below, but that's not the case (as can be seen by deleting that note head).
So it's probably best to forget my remark after all. Anyway, this was not
influenced by your change of thickness, so you might just as well follow your
judgement about what look of the symbol matches the Feta 'flavour'.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b