Issue 340120043: [l2tdevtools] Moved reviewer selection functions #255

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 340120043: [l2tdevtools] Moved reviewer selection functions #255 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 3 months ago by Joachim Metz

Modified:
6 years, 3 months ago

Reviewers:
jberggren, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[l2tdevtools] Moved reviewer selection functions #255

Patch Set 2 : Changes after review #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -367 lines)			Patch
M	l2tdevtools/helpers/cli.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
D	l2tdevtools/helpers/project.py	View		1 chunk	+0 lines, -245 lines	0 comments	Download
A +	l2tdevtools/helpers/projects.py	View		4 chunks	+91 lines, -2 lines	0 comments	Download
M	l2tdevtools/helpers/review.py	View	1	7 chunks	+10 lines, -10 lines	0 comments	Download
M	l2tdevtools/helpers/upload.py	View		4 chunks	+5 lines, -87 lines	0 comments	Download
M	tests/helpers/github.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
D	tests/helpers/project.py	View		1 chunk	+0 lines, -22 lines	0 comments	Download
A	tests/helpers/projects.py	View		1 chunk	+52 lines, -0 lines	0 comments	Download
M	tests/helpers/upload.py	View		2 chunks	+38 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

onager

https://codereview.appspot.com/340120043/diff/1/l2tdevtools/helpers/github.py File l2tdevtools/helpers/github.py (right): https://codereview.appspot.com/340120043/diff/1/l2tdevtools/helpers/github.py#newcode82 l2tdevtools/helpers/github.py:82: """Queries a github user. Please fix - the docstring ...

6 years, 3 months ago (2018-01-11 13:05:30 UTC) #2

Joachim Metz

6 years, 3 months ago (2018-01-11 19:20:45 UTC) #3

Joachim Metz

6 years, 3 months ago (2018-01-15 06:34:42 UTC) #6

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close reviewers

Expand All Messages | Collapse All Messages