Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(638)

Issue 340120043: [l2tdevtools] Moved reviewer selection functions #255 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by Joachim Metz
Modified:
1 day, 5 hours ago
Reviewers:
jberggren, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[l2tdevtools] Moved reviewer selection functions #255

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -367 lines) Patch
M l2tdevtools/helpers/cli.py View 1 chunk +1 line, -0 lines 0 comments Download
D l2tdevtools/helpers/project.py View 1 chunk +0 lines, -245 lines 0 comments Download
A + l2tdevtools/helpers/projects.py View 4 chunks +91 lines, -2 lines 0 comments Download
M l2tdevtools/helpers/review.py View 1 7 chunks +10 lines, -10 lines 0 comments Download
M l2tdevtools/helpers/upload.py View 4 chunks +5 lines, -87 lines 0 comments Download
M tests/helpers/github.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
D tests/helpers/project.py View 1 chunk +0 lines, -22 lines 0 comments Download
A tests/helpers/projects.py View 1 chunk +52 lines, -0 lines 0 comments Download
M tests/helpers/upload.py View 2 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 6
Joachim Metz
1 week, 2 days ago (2018-01-07 09:28:28 UTC) #1
onager
https://codereview.appspot.com/340120043/diff/1/l2tdevtools/helpers/github.py File l2tdevtools/helpers/github.py (right): https://codereview.appspot.com/340120043/diff/1/l2tdevtools/helpers/github.py#newcode82 l2tdevtools/helpers/github.py:82: """Queries a github user. Please fix - the docstring ...
4 days, 22 hours ago (2018-01-11 13:05:30 UTC) #2
Joachim Metz
https://codereview.appspot.com/340120043/diff/1/l2tdevtools/helpers/github.py File l2tdevtools/helpers/github.py (right): https://codereview.appspot.com/340120043/diff/1/l2tdevtools/helpers/github.py#newcode82 l2tdevtools/helpers/github.py:82: """Queries a github user. I'll remove it
4 days, 16 hours ago (2018-01-11 19:20:45 UTC) #3
Joachim Metz
Code updated.
4 days, 16 hours ago (2018-01-11 19:21:18 UTC) #4
onager
LGTM
1 day, 11 hours ago (2018-01-15 00:29:55 UTC) #5
Joachim Metz
1 day, 5 hours ago (2018-01-15 06:34:42 UTC) #6
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close reviewers
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d