Issue 339880043: adding SixEPwriter.java

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 339880043: adding SixEPwriter.java

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 5 months ago by dima.alissa

Modified:
6 years, 5 months ago

Reviewers:
safa.ismail.si, dkostic, mustafa.alabaychi, voravitt, robert.herjulf.olsson, armangungor, Alaiin

Visibility:
Public.

More Reviews

Description

adding SixEPwriter.java BUG=

Patch Set 1 #

Total comments: 6

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -0 lines)			Patch
	A	IoT_internal/SixEpWriter.java	View		1 chunk	+112 lines, -0 lines	6 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dima.alissa

please review the the SixEPwriter that is representing the Encapsulation function before sending them to ...

6 years, 5 months ago (2017-11-22 08:43:55 UTC) #1

mustafa.alabaychi

6 years, 5 months ago (2017-11-22 09:28:26 UTC) #2

Thank you Dima. Good work!

https://codereview.appspot.com/339880043/diff/1/IoT_internal/SixEpWriter.java
File IoT_internal/SixEpWriter.java (right):

https://codereview.appspot.com/339880043/diff/1/IoT_internal/SixEpWriter.java...
IoT_internal/SixEpWriter.java:15: String sicsEPaddr="130.237.20.137";//6EP IP
address
possibly we can extract the IP address of the 6EP from the tunnel object that is
passed to this object to avoid repetition.

we use SixEpWriter as the name of the class. Possibly we can be more consistent
and name this variable as SixEpAddr?

https://codereview.appspot.com/339880043/diff/1/IoT_internal/SixEpWriter.java...
IoT_internal/SixEpWriter.java:16: InetAddress sepAddress;
possibly sixEpAddrress is a better name?

https://codereview.appspot.com/339880043/diff/1/IoT_internal/SixEpWriter.java...
IoT_internal/SixEpWriter.java:17: private int sepPort=666;
same with the name

https://codereview.appspot.com/339880043/diff/1/IoT_internal/SixEpWriter.java...
IoT_internal/SixEpWriter.java:77: this.outDataBuf.clear();
it is good to write the reason why we have this line. Preparing the buffer for
writing? right?

https://codereview.appspot.com/339880043/diff/1/IoT_internal/SixEpWriter.java...
IoT_internal/SixEpWriter.java:86: //this.sepAddress=dp.getAddress(); //for demo
purpose only
line not used. Maybe it is better to be deleted

https://codereview.appspot.com/339880043/diff/1/IoT_internal/SixEpWriter.java...
IoT_internal/SixEpWriter.java:96: this.outDataBuf.flip();
here we can add comment. Prepare for reading from the buffer.

Expand All Messages | Collapse All Messages