Issue 339830043: hum

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 5 months ago by 2016shana2333

Modified:
6 years, 5 months ago

Reviewers:
engr.sikandar.iqbal, 2016shana2333, Vasileios Papageorgiou, dkostic, paul.busi38, michail.xirouchakis, alireza.farshin

CC:
sdnik2200ht17_ict.kth.se

Visibility:
Public.

More Reviews

Description

hum BUG=

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	HUM/hum.py	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Vasileios Papageorgiou

6 years, 5 months ago (2017-11-26 11:01:01 UTC) #2

Hi Jiatong,

I made comments on your HUM latest implementation.

BR,

Vasileios Papageorgiou

https://codereview.appspot.com/339830043/diff/1/HUM/hum.py
File HUM/hum.py (right):

https://codereview.appspot.com/339830043/diff/1/HUM/hum.py#newcode73
HUM/hum.py:73: # Connect with DM:
Is the connection with dm working now?

https://codereview.appspot.com/339830043/diff/1/HUM/hum.py#newcode87
HUM/hum.py:87: # 5for proc status not use in this project
i don't understand what you mean here.

Expand All Messages | Collapse All Messages