[l2tdevtools] Changes for yapf dpkg package

[l2tdevtools] Changes for yapf dpkg package

[Joachim Metz, 2018-03-19 18:42:44]

Code updated.

[onager, 2018-03-20 09:08:30]

https://codereview.appspot.com/339380043/diff/20001/.style.yapf
File .style.yapf (right):

https://codereview.appspot.com/339380043/diff/20001/.style.yapf#newcode7
.style.yapf:7: split_penalty_after_opening_bracket = 0
Why drop spaces_before_comment? This is different to what we have in the
codebase.

https://codereview.appspot.com/339380043/diff/20001/data/projects.ini
File data/projects.ini (right):

https://codereview.appspot.com/339380043/diff/20001/data/projects.ini#newcode...
data/projects.ini:1744: build_options: python2_only
Does this not build under python2? What was the issue?

[Joachim Metz, 2018-03-20 19:43:57]

https://codereview.appspot.com/339380043/diff/20001/.style.yapf
File .style.yapf (right):

https://codereview.appspot.com/339380043/diff/20001/.style.yapf#newcode7
.style.yapf:7: split_penalty_after_opening_bracket = 0
that is the default for chromium as far as I could tell

https://codereview.appspot.com/339380043/diff/20001/data/projects.ini
File data/projects.ini (right):

https://codereview.appspot.com/339380043/diff/20001/data/projects.ini#newcode...
data/projects.ini:1744: build_options: python2_only
On 2018/03/20 09:08:30, onager wrote:
> Does this not build under python2? What was the issue?

this builds both under python2 and python3 but we use the yapf tool not the
yapf3 tool, so we only need python2 support

[onager, 2018-03-20 19:49:17]

https://codereview.appspot.com/339380043/diff/20001/.style.yapf
File .style.yapf (right):

https://codereview.appspot.com/339380043/diff/20001/.style.yapf#newcode7
.style.yapf:7: split_penalty_after_opening_bracket = 0
On 2018/03/20 19:43:56, Joachim Metz wrote:
> that is the default for chromium as far as I could tell

Doesn't look like it:
https://github.com/google/yapf/blob/master/yapf/yapflib/style.py#L319

[Joachim Metz, 2018-03-20 20:01:00]

https://codereview.appspot.com/339380043/diff/20001/.style.yapf
File .style.yapf (right):

https://codereview.appspot.com/339380043/diff/20001/.style.yapf#newcode7
.style.yapf:7: split_penalty_after_opening_bracket = 0
I ran:

yapf --style=chromium --style-help | grep -i SPACES_BEFORE_COMMENT

this returns:

spaces_before_comment=2

But I can re-add it if you think it might change

[onager, 2018-03-20 20:20:17]

LGTM

https://codereview.appspot.com/339380043/diff/20001/.style.yapf
File .style.yapf (right):

https://codereview.appspot.com/339380043/diff/20001/.style.yapf#newcode7
.style.yapf:7: split_penalty_after_opening_bracket = 0
On 2018/03/20 20:01:00, Joachim Metz wrote:
> I ran:
> 
> yapf --style=chromium --style-help | grep -i SPACES_BEFORE_COMMENT
> 
> this returns:
> 
> spaces_before_comment=2
> 
> But I can re-add it if you think it might change

OK, this does seem to be set in chromium - I guess it's a yapf default.

[Joachim Metz, 2018-03-20 20:47:10]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close yapf