Issue 338660043: [plaso] Improved event heaps test coverage and clean up

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 338660043: [plaso] Improved event heaps test coverage and clean up (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
6 years ago

Reviewers:
jberggren

CC:
kiddi, log2timeline-dev_googlegroups.com, romaing, onager

Visibility:
Public.

More Reviews

Description

[plaso] Improved event heaps test coverage and clean up

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+208 lines, -18 lines)			Patch
M	tests/containers/test_lib.py	View	1 chunk	+14 lines, -5 lines	0 comments	Download
M	tests/formatters/interface.py	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/multi_processing/psort.py	View	2 chunks	+51 lines, -9 lines	0 comments	Download
M	tests/storage/event_heaps.py	View	1 chunk	+138 lines, -1 line	2 comments	Download
M	tests/storage/interface.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jberggren

https://codereview.appspot.com/338660043/diff/1/tests/storage/event_heaps.py File tests/storage/event_heaps.py (right): https://codereview.appspot.com/338660043/diff/1/tests/storage/event_heaps.py#newcode34 tests/storage/event_heaps.py:34: event1 = containers_test_lib.TestEvent(5134324321) I'm not sure what these numbers ...

6 years ago (2018-04-05 08:20:26 UTC) #2

Joachim Metz

6 years ago (2018-04-06 04:52:21 UTC) #3

jberggren

On 2018/04/06 04:52:21, Joachim Metz wrote: > https://codereview.appspot.com/338660043/diff/1/tests/storage/event_heaps.py > File tests/storage/event_heaps.py (right): > > https://codereview.appspot.com/338660043/diff/1/tests/storage/event_heaps.py#newcode34 ...

6 years ago (2018-04-23 08:56:11 UTC) #4

Joachim Metz

6 years ago (2018-04-23 17:17:23 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close clean1

Expand All Messages | Collapse All Messages