Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(421)

Issue 338460043: [plaso] Refactored timestamp checks in tests #1701 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by Joachim Metz
Modified:
7 months, 4 weeks ago
Reviewers:
romaing
CC:
jberggren, onager, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Refactored timestamp checks in tests #1701

Patch Set 1 #

Patch Set 2 : Refactored timestamp checks in tests #1701 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -236 lines) Patch
M tests/parsers/sqlite_plugins/kik_ios.py View 2 chunks +4 lines, -13 lines 0 comments Download
M tests/parsers/sqlite_plugins/ls_quarantine.py View 3 chunks +3 lines, -10 lines 0 comments Download
M tests/parsers/sqlite_plugins/mac_document_versions.py View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/parsers/sqlite_plugins/mackeeper_cache.py View 2 chunks +1 line, -4 lines 0 comments Download
M tests/parsers/sqlite_plugins/safari.py View 2 chunks +3 lines, -7 lines 0 comments Download
M tests/parsers/sqlite_plugins/skype.py View 7 chunks +15 lines, -24 lines 0 comments Download
M tests/parsers/sqlite_plugins/twitter_ios.py View 5 chunks +8 lines, -13 lines 0 comments Download
M tests/parsers/sqlite_plugins/zeitgeist.py View 2 chunks +2 lines, -6 lines 0 comments Download
M tests/parsers/symantec.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/parsers/syslog.py View 5 chunks +6 lines, -19 lines 0 comments Download
M tests/parsers/syslog_plugins/cron.py View 2 chunks +2 lines, -6 lines 0 comments Download
M tests/parsers/syslog_plugins/ssh.py View 3 chunks +3 lines, -6 lines 0 comments Download
M tests/parsers/systemd_journal.py View 5 chunks +4 lines, -13 lines 0 comments Download
M tests/parsers/utmp.py View 4 chunks +3 lines, -10 lines 0 comments Download
M tests/parsers/utmpx.py View 4 chunks +4 lines, -10 lines 0 comments Download
M tests/parsers/winevt.py View 3 chunks +2 lines, -8 lines 0 comments Download
M tests/parsers/winevtx.py View 2 chunks +1 line, -4 lines 0 comments Download
M tests/parsers/winfirewall.py View 2 chunks +2 lines, -7 lines 0 comments Download
M tests/parsers/winjob.py View 3 chunks +2 lines, -7 lines 0 comments Download
M tests/parsers/winlnk.py View 4 chunks +5 lines, -16 lines 0 comments Download
M tests/parsers/winprefetch.py View 12 chunks +21 lines, -43 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
8 months, 1 week ago (2018-02-04 15:46:57 UTC) #1
romaing
LGTM
8 months ago (2018-02-12 14:48:43 UTC) #2
Joachim Metz
Code updated.
7 months, 4 weeks ago (2018-02-19 18:42:39 UTC) #3
Joachim Metz
7 months, 4 weeks ago (2018-02-19 18:48:24 UTC) #4
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close testing5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b