Issue 338460043: [plaso] Refactored timestamp checks in tests #1701

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 338460043: [plaso] Refactored timestamp checks in tests #1701 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 2 months ago by Joachim Metz

Modified:
6 years, 2 months ago

Reviewers:
romaing

CC:
jberggren, onager, kiddi, log2timeline-dev_googlegroups.com, aaronp

Visibility:
Public.

More Reviews

Description

[plaso] Refactored timestamp checks in tests #1701

Patch Set 1 #

Patch Set 2 : Refactored timestamp checks in tests #1701 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -236 lines)			Patch
M	tests/parsers/sqlite_plugins/kik_ios.py	View	2 chunks	+4 lines, -13 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/ls_quarantine.py	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/mac_document_versions.py	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/mackeeper_cache.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/safari.py	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/skype.py	View	7 chunks	+15 lines, -24 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/twitter_ios.py	View	5 chunks	+8 lines, -13 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/zeitgeist.py	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	tests/parsers/symantec.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/parsers/syslog.py	View	5 chunks	+6 lines, -19 lines	0 comments	Download
M	tests/parsers/syslog_plugins/cron.py	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	tests/parsers/syslog_plugins/ssh.py	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	tests/parsers/systemd_journal.py	View	5 chunks	+4 lines, -13 lines	0 comments	Download
M	tests/parsers/utmp.py	View	4 chunks	+3 lines, -10 lines	0 comments	Download
M	tests/parsers/utmpx.py	View	4 chunks	+4 lines, -10 lines	0 comments	Download
M	tests/parsers/winevt.py	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	tests/parsers/winevtx.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/parsers/winfirewall.py	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	tests/parsers/winjob.py	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	tests/parsers/winlnk.py	View	4 chunks	+5 lines, -16 lines	0 comments	Download
M	tests/parsers/winprefetch.py	View	12 chunks	+21 lines, -43 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Joachim Metz

6 years, 2 months ago (2018-02-19 18:48:24 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close testing5

Expand All Messages | Collapse All Messages