Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1929)

Issue 337720043: Prototype for get 20 samples on a specific path

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by Wei Wang
Modified:
6 years, 6 months ago
CC:
farzad2050, yulianlluo, zhubiwen509, Wei Wang
Visibility:
Public.

Description

The folder is a prototype for get 20 samples on a specific path(from Ireland to Tokyo) with equal distance. I'll keep adding more paths. For more descriptions, please check "README" in this folder.

Patch Set 1 #

Total comments: 8

Patch Set 2 : show results #

Patch Set 3 : add arrows over the path #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M .DS_Store View 1 2 Binary file 0 comments Download
M Sample_Points_Prototype/.DS_Store View 1 2 Binary file 0 comments Download
M Sample_Points_Prototype/README View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M Sample_Points_Prototype/index.html View 1 2 4 chunks +54 lines, -2 lines 5 comments Download
A Sample_Points_Prototype/with_path.png View 1 2 Binary file 0 comments Download

Messages

Total messages: 9
Wei Wang
6 years, 6 months ago (2017-10-19 09:11:22 UTC) #1
Wei Wang
https://codereview.appspot.com/337720043/diff/40001/Sample_Points_Prototype/index.html File Sample_Points_Prototype/index.html (right): https://codereview.appspot.com/337720043/diff/40001/Sample_Points_Prototype/index.html#newcode110 Sample_Points_Prototype/index.html:110: Note: I try to add circle on each point. ...
6 years, 6 months ago (2017-10-19 15:16:49 UTC) #2
manu_chaud
https://codereview.appspot.com/337720043/diff/1/Sample_Points_Prototype/index.html File Sample_Points_Prototype/index.html (right): https://codereview.appspot.com/337720043/diff/1/Sample_Points_Prototype/index.html#newcode42 Sample_Points_Prototype/index.html:42: // var city = markerElem.getAttribute('city'); Whenever a hop is ...
6 years, 6 months ago (2017-10-22 00:47:19 UTC) #3
brahim Al-Qaysi
https://codereview.appspot.com/337720043/diff/1/Sample_Points_Prototype/index.html File Sample_Points_Prototype/index.html (right): https://codereview.appspot.com/337720043/diff/1/Sample_Points_Prototype/index.html#newcode40 Sample_Points_Prototype/index.html:40: // var ipSrc = markerElem.getAttribute('ipSrc'); Remove if they are ...
6 years, 6 months ago (2017-10-22 11:36:19 UTC) #4
brahim Al-Qaysi
On 2017/10/19 09:11:22, Wei Wang wrote: Wei can you add the other picture were the ...
6 years, 6 months ago (2017-10-22 15:50:21 UTC) #5
manu_chaud
On 2017/10/22 15:50:21, brahim Al-Qaysi wrote: > On 2017/10/19 09:11:22, Wei Wang wrote: > > ...
6 years, 6 months ago (2017-10-22 15:53:14 UTC) #6
brahim Al-Qaysi
On 2017/10/22 15:53:14, manu_chaud wrote: > On 2017/10/22 15:50:21, brahim Al-Qaysi wrote: > > On ...
6 years, 6 months ago (2017-10-22 16:02:00 UTC) #7
manu_chaud
On 2017/10/22 16:02:00, brahim Al-Qaysi wrote: > On 2017/10/22 15:53:14, manu_chaud wrote: > > On ...
6 years, 6 months ago (2017-10-22 16:03:53 UTC) #8
Wei Wang
6 years, 6 months ago (2017-10-22 18:04:42 UTC) #9
https://codereview.appspot.com/337720043/diff/1/Sample_Points_Prototype/index...
File Sample_Points_Prototype/index.html (right):

https://codereview.appspot.com/337720043/diff/1/Sample_Points_Prototype/index...
Sample_Points_Prototype/index.html:40: // var ipSrc =
markerElem.getAttribute('ipSrc');
On 2017/10/22 11:36:19, brahim Al-Qaysi wrote:
> Remove if they are not needed

Yes. Thank you for the mention. 
I haven't deleted some of them because they may be used later. Showing IPsec is
necessary I think.  
At last, I will remove some useless codes.

https://codereview.appspot.com/337720043/diff/1/Sample_Points_Prototype/index...
Sample_Points_Prototype/index.html:42: // var city =
markerElem.getAttribute('city');
On 2017/10/22 00:47:19, manu_chaud wrote:
> Whenever a hop is in the water, we could consider to give just its
coordinates,
> or maybe its id (if necessary?), instead of displaying an empty infoWindow
> What do you think?

Yes, they shouldn't be empty and should be added with IP info. 
I'll fix this problem in my next step.

https://codereview.appspot.com/337720043/diff/1/Sample_Points_Prototype/index...
Sample_Points_Prototype/index.html:72: // 把 XML 文档解析到 XML DOM 对象中:
On 2017/10/22 11:36:19, brahim Al-Qaysi wrote:
> change language

Yes sorry. I forgot this.

https://codereview.appspot.com/337720043/diff/40001/Sample_Points_Prototype/i...
File Sample_Points_Prototype/index.html (right):

https://codereview.appspot.com/337720043/diff/40001/Sample_Points_Prototype/i...
Sample_Points_Prototype/index.html:63: size:4,
On 2017/10/22 00:47:19, manu_chaud wrote:
> the size property doesn't seem to be valid for the MarkerOptions object:
>
https://developers.google.com/maps/documentation/javascript/3.exp/reference#M...

Correct. I also found this bug......

https://codereview.appspot.com/337720043/diff/40001/Sample_Points_Prototype/i...
Sample_Points_Prototype/index.html:110: 
On 2017/10/22 00:47:19, manu_chaud wrote:
> On 2017/10/19 15:16:49, Wei Wang wrote:
> > Note: I try to add circle on each point. But according to every running
> result,
> > it still happens with the normal Google marker. Till now, didn't find a
> solution
> > to solve it.  
> > Anyway, this folder has met an overall requirement which is sample points
> along
> > with a specific path between 2 datacenters.
> > @emmanuel  I think you may have some ideas to fix this problem. 
> 
> Will be fixed in a next patch.

Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b