Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4364)

Issue 3377041: code review 3377041: math: fix Exp2 for integer exponents

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by peterGo
Modified:
13 years, 4 months ago
Reviewers:
CC:
golang-dev
Visibility:
Public.

Description

math: fix Exp2 for integer exponents For non-negative integer exponents, the results for floating-point and integer arithmetic should be the same.

Patch Set 1 #

Patch Set 2 : code review 3377041: math: fix Exp2 for integer exponents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/pkg/math/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/math/all_test.go View 1 chunk +14 lines, -0 lines 0 comments Download
M src/pkg/math/exp2.go View 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/math/exp2_amd64.s View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3
peterGo
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 5 months ago (2010-12-01 21:10:56 UTC) #1
ejsherry
I don't think special casing 0 to 63 is such a good idea. Exp2 will ...
13 years, 4 months ago (2010-12-04 02:47:56 UTC) #2
rsc1
13 years, 4 months ago (2010-12-06 19:38:45 UTC) #3
Closing in favor of ejsherry's CL 3481041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b