code review 33760043: misc/vim: send Fmt errors to the quickfix list instead ...

misc/vim: send Fmt errors to the quickfix list instead of the location list.

Output from gofmt is a list of errors, so they should appear in the error list.

[dsymonds, 2013-11-27 08:14:12]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2013-11-27 08:30:51]

LGTM

On Wednesday, 27 November 2013, wrote:

> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> misc/vim: send Fmt errors to the quickfix list instead of the location
> list.
>
> Output from gofmt is a list of errors, so they should appear in the
> error list.
>
> Please review this at https://codereview.appspot.com/33760043/
>
> Affected files (+1, -1 lines):
>   M misc/vim/ftplugin/go/fmt.vim
>
>
> Index: misc/vim/ftplugin/go/fmt.vim
> ===================================================================
> --- a/misc/vim/ftplugin/go/fmt.vim
> +++ b/misc/vim/ftplugin/go/fmt.vim
> @@ -57,7 +57,7 @@
>          endif
>          undo
>          if !empty(errors)
> -            call setloclist(0, errors, 'r')
> +            call setqflist(errors, 'r')
>          endif
>          echohl Error | echomsg "Gofmt returned error" | echohl None
>      endif
>
>
>

[dsymonds, 2013-11-27 08:31:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=bddf2a72f5e1 ***

misc/vim: send Fmt errors to the quickfix list instead of the location list.

Output from gofmt is a list of errors, so they should appear in the error list.

R=adg
CC=golang-dev
https://codereview.appspot.com/33760043

[dsymonds, 2013-11-27 08:33:22]

adg told me to submit this, but it turned out he was joking. Just don't
cherry-pick this onto the release branch.