Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(413)

Issue 337520043: Issue 5272: Add \depart <markup>

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Dan Eble
Modified:
2 years, 7 months ago
Reviewers:
rcb, c_sorensen, dan, lemzwerg, dak, simon.albrecht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5272/ Add \depart <markup> command to make it unnecessary to continue abusing rehearsal marks for instructions such as "D.C." It solves these problems that rehearsal marks alone could not solve: * It is possible to change the default direction of departure marks without changing the default direction of rehearsal marks. * It is possible to use a departure mark and a rehearsal mark at the same moment.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -0 lines) Patch
M Documentation/changes.tely View 1 chunk +10 lines, -0 lines 0 comments Download
A input/regression/departure-mark-instrumental.ly View 1 chunk +46 lines, -0 lines 1 comment Download
A input/regression/departure-mark-vocal.ly View 1 chunk +49 lines, -0 lines 1 comment Download
A lily/departure-mark-engraver.cc View 1 chunk +136 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +5 lines, -0 lines 0 comments Download
M scm/define-event-classes.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +36 lines, -0 lines 0 comments Download
M scm/define-music-types.scm View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13
Dan Eble
I would be happy to hear suggestions for the name of this command. My opinion ...
2 years, 7 months ago (2018-02-07 01:44:19 UTC) #1
simon.albrecht
Brainstorming (NB, only brainstorming) on the name: Normal rehearsal marks refer to the beginning of ...
2 years, 7 months ago (2018-02-07 02:12:59 UTC) #2
dan_faithful.be
On Feb 6, 2018, at 21:12, Simon Albrecht <simon.albrecht@mail.de> wrote: > > Brainstorming (NB, only ...
2 years, 7 months ago (2018-02-07 04:00:10 UTC) #3
lemzwerg
Very nice idea! > On the other hand, \goTo seems unlikely to resemble whatever > ...
2 years, 7 months ago (2018-02-07 06:34:32 UTC) #4
lemzwerg
https://codereview.appspot.com/337520043/diff/1/input/regression/departure-mark-instrumental.ly File input/regression/departure-mark-instrumental.ly (right): https://codereview.appspot.com/337520043/diff/1/input/regression/departure-mark-instrumental.ly#newcode4 input/regression/departure-mark-instrumental.ly:4: texidoc="By default, departure marks are end-of-line-visible, right-aligned, and below ...
2 years, 7 months ago (2018-02-07 06:34:44 UTC) #5
dak
On 2018/02/07 06:34:32, lemzwerg wrote: > Very nice idea! > > > On the other ...
2 years, 7 months ago (2018-02-07 09:36:23 UTC) #6
lemzwerg
> \location or \place, with LocationMark or PlaceMark to match? \location sounds excellent.
2 years, 7 months ago (2018-02-07 09:40:40 UTC) #7
c_sorensen
How about \flow and FlowScript? Carl Sent via the Samsung Galaxy S®6 active, an AT&T ...
2 years, 7 months ago (2018-02-07 12:50:44 UTC) #8
rcb_dabble.ch
(new here because gmane is dud) This is a signpost at a fork in the ...
2 years, 7 months ago (2018-02-07 13:22:32 UTC) #9
dan_faithful.be
On Feb 6, 2018, at 20:44, nine.fierce.ballads@gmail.com wrote: > > Reviewers: , > > Message: ...
2 years, 7 months ago (2018-02-08 03:12:35 UTC) #10
dak
Dan Eble <dan@faithful.be> writes: > On Feb 6, 2018, at 20:44, nine.fierce.ballads@gmail.com wrote: >> >> ...
2 years, 7 months ago (2018-02-08 08:59:02 UTC) #11
Dan Eble
On 2018/02/08 03:12:35, dan_faithful.be wrote: > For convenience, I would like to predefine the label ...
2 years, 7 months ago (2018-02-08 12:40:23 UTC) #12
Dan Eble
2 years, 7 months ago (2018-02-08 12:50:54 UTC) #13
On 2018/02/08 08:59:02, dak wrote:
> Wouldn't it rather be \jump <key-list> <markup> ?  The whole point of
> repeat constructs being that they do something different every time (or
> we'll never end anyway).

Mmm... I'll have to think about that.  That relates to something else that
I've wished for (and worked on), which is the ability to include
volta-specific alternatives in the main body of a repeated sequence,
not just at the tail.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b