Issue 337470043: [plaso] Optimized count queries in SQLite storage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 337470043: [plaso] Optimized count queries in SQLite storage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 1 month ago by onager

Modified:
8 years, 1 month ago

Reviewers:
Joachim Metz

CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp

Visibility:
Public.

More Reviews

Description

[plaso] Optimized count queries in SQLite storage

Patch Set 1 #

Total comments: 8

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -42 lines)			Patch
	M	plaso/storage/sqlite/sqlite_file.py	View		7 chunks	+39 lines, -42 lines	8 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Joachim Metz

Some small issues, please fix before merge, overall LGTM https://codereview.appspot.com/337470043/diff/1/plaso/storage/sqlite/sqlite_file.py File plaso/storage/sqlite/sqlite_file.py (right): https://codereview.appspot.com/337470043/diff/1/plaso/storage/sqlite/sqlite_file.py#newcode487 plaso/storage/sqlite/sqlite_file.py:487: ...

8 years, 1 month ago (2018-01-11 17:32:18 UTC) #2

onager

https://codereview.appspot.com/337470043/diff/1/plaso/storage/sqlite/sqlite_file.py File plaso/storage/sqlite/sqlite_file.py (right): https://codereview.appspot.com/337470043/diff/1/plaso/storage/sqlite/sqlite_file.py#newcode487 plaso/storage/sqlite/sqlite_file.py:487: int: number of attribute containers of the given type. ...

8 years, 1 month ago (2018-01-11 20:32:58 UTC) #3

onager

8 years, 1 month ago (2018-01-11 20:39:17 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close countcontainers

Expand All Messages | Collapse All Messages