Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(294)

Issue 337470043: [plaso] Optimized count queries in SQLite storage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by onager
Modified:
5 months, 1 week ago
Reviewers:
Joachim Metz
CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Optimized count queries in SQLite storage

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -42 lines) Patch
M plaso/storage/sqlite/sqlite_file.py View 7 chunks +39 lines, -42 lines 8 comments Download

Messages

Total messages: 4
onager
5 months, 1 week ago (2018-01-11 17:15:01 UTC) #1
Joachim Metz
Some small issues, please fix before merge, overall LGTM https://codereview.appspot.com/337470043/diff/1/plaso/storage/sqlite/sqlite_file.py File plaso/storage/sqlite/sqlite_file.py (right): https://codereview.appspot.com/337470043/diff/1/plaso/storage/sqlite/sqlite_file.py#newcode487 plaso/storage/sqlite/sqlite_file.py:487: ...
5 months, 1 week ago (2018-01-11 17:32:18 UTC) #2
onager
https://codereview.appspot.com/337470043/diff/1/plaso/storage/sqlite/sqlite_file.py File plaso/storage/sqlite/sqlite_file.py (right): https://codereview.appspot.com/337470043/diff/1/plaso/storage/sqlite/sqlite_file.py#newcode487 plaso/storage/sqlite/sqlite_file.py:487: int: number of attribute containers of the given type. ...
5 months, 1 week ago (2018-01-11 20:32:58 UTC) #3
onager
5 months, 1 week ago (2018-01-11 20:39:17 UTC) #4
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close countcontainers
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b