Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90)

Issue 336970043: Eliminate Visual Studio compiler warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ammo6818-vandals.uidaho.edu
Modified:
16 hours, 35 minutes ago
Reviewers:
Peter Barnes
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Patch Set 2 : Additional updates #

Patch Set 3 : Updates to use C++ style type casts #

Patch Set 4 : Updated patch set to reduce number of casts #

Patch Set 5 : Updates to patch set to eliminate some casts. Add ability to tolerate multiple class registrations… #

Patch Set 6 : Patch updates for x64 build #

Patch Set 7 : Additional changes for x64 build #

Patch Set 8 : Patch updates to resolve review comments #

Patch Set 9 : Updates to patch for review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -243 lines) Patch
M src/core/examples/command-line-example.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/core/examples/hash-example.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/core/examples/main-test-sync.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/core/examples/sample-log-time-format.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/helper/random-variable-stream-helper.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/model/assert.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/model/attribute-accessor-helper.h View 2 3 chunks +5 lines, -0 lines 0 comments Download
M src/core/model/cairo-wideint.c View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -7 lines 0 comments Download
M src/core/model/calendar-scheduler.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/model/calendar-scheduler.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -6 lines 0 comments Download
M src/core/model/command-line.cc View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -5 lines 0 comments Download
M src/core/model/config.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/model/config.cc View 1 2 3 4 5 6 7 8 8 chunks +17 lines, -17 lines 0 comments Download
M src/core/model/hash-fnv.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/model/hash-murmur3.cc View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -7 lines 0 comments Download
M src/core/model/heap-scheduler.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/core/model/heap-scheduler.cc View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -5 lines 0 comments Download
M src/core/model/int64x64-cairo.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/model/int64x64-cairo.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/model/int64x64-double.h View 1 2 3 4 5 6 7 3 chunks +6 lines, -5 lines 0 comments Download
M src/core/model/log.h View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M src/core/model/log.cc View 1 2 3 4 5 6 7 1 chunk +32 lines, -0 lines 0 comments Download
M src/core/model/nstime.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/core/model/object.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/core/model/object-base.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/core/model/object-base.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/model/object-map.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/model/object-ptr-container.h View 1 2 3 4 5 6 7 8 7 chunks +9 lines, -9 lines 0 comments Download
M src/core/model/object-ptr-container.cc View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -7 lines 0 comments Download
M src/core/model/object-vector.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/model/random-variable-stream.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/model/random-variable-stream.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/model/realtime-simulator-impl.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/model/rng-seed-manager.cc View 1 2 3 4 5 6 7 3 chunks +11 lines, -11 lines 0 comments Download
M src/core/model/simple-ref-count.h View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -1 line 0 comments Download
M src/core/model/simulator.h View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -2 lines 0 comments Download
M src/core/model/synchronizer.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/model/system-path.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/model/test.h View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -7 lines 0 comments Download
M src/core/model/type-id.h View 1 2 3 4 5 6 7 8 4 chunks +9 lines, -9 lines 0 comments Download
M src/core/model/type-id.cc View 1 2 3 4 5 6 7 8 16 chunks +42 lines, -41 lines 0 comments Download
M src/core/model/vector.h View 1 2 2 chunks +47 lines, -2 lines 0 comments Download
M src/core/model/wall-clock-synchronizer.h View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
M src/core/model/wall-clock-synchronizer.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/core/test/attribute-test-suite.cc View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -5 lines 0 comments Download
M src/core/test/callback-test-suite.cc View 2 3 chunks +5 lines, -4 lines 0 comments Download
M src/core/test/config-test-suite.cc View 2 3 chunks +3 lines, -2 lines 0 comments Download
M src/core/test/int64x64-test-suite.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/test/random-variable-stream-test-suite.cc View 1 2 3 4 5 6 7 4 chunks +8 lines, -4 lines 0 comments Download
M src/core/test/simulator-test-suite.cc View 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/test/traced-callback-test-suite.cc View 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/core/test/type-id-test-suite.cc View 1 2 3 4 5 6 7 4 chunks +7 lines, -5 lines 0 comments Download
M src/lte/examples/lena-intercell-interference.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/lte/examples/lena-pathloss-traces.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/lte/examples/lena-profiling.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/lte/examples/lena-simple-epc.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/lte/examples/lena-simple-epc-emu.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/lte-test-cell-selection.cc View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-phy-error-model.cc View 1 2 3 4 5 6 7 8 5 chunks +6 lines, -6 lines 0 comments Download
M src/lte/test/lte-test-rlc-am-e2e.cc View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -13 lines 0 comments Download
M src/lte/test/lte-test-secondary-cell-selection.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/stats/helper/file-helper.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/stats/helper/gnuplot-helper.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
ammo6818-vandals.uidaho.edu
16 hours, 35 minutes ago (2018-02-18 05:44:41 UTC) #1
Please let me know if there are any other review comments or merge into ns-3-dev
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d