code review 33650044: freetype/truetype: upgrade testdata to C Freetype 2.5.1.

freetype/truetype: upgrade testdata to C Freetype 2.5.1.

[nigeltao, 2013-11-27 10:16:04]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com,
remyoudompheng@gmail.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-11-27 13:28:48]

LGTM

https://codereview.appspot.com/33650044/diff/60001/freetype/truetype/truetype...
File freetype/truetype/truetype_test.go (right):

https://codereview.appspot.com/33650044/diff/60001/freetype/truetype/truetype...
freetype/truetype/truetype_test.go:268: 269:  true,
Why are there more exceptions now?

https://codereview.appspot.com/33650044/diff/60001/freetype/truetype/truetype...
freetype/truetype/truetype_test.go:322: continue
Should this be an error, or would a warning be better?

[nigeltao, 2013-11-28 03:00:57]

https://codereview.appspot.com/33650044/diff/60001/freetype/truetype/truetype...
File freetype/truetype/truetype_test.go (right):

https://codereview.appspot.com/33650044/diff/60001/freetype/truetype/truetype...
freetype/truetype/truetype_test.go:268: 269:  true,
On 2013/11/27 13:28:49, bsiegert wrote:
> Why are there more exceptions now?

Because the previous Go code matched C Freetype 2.5.0's behavior (apart from
four exceptions). Some of that behavior changed with C Freetype 2.5.1. Glyph 269
is a regression
(http://lists.nongnu.org/archive/html/freetype/2013-11/msg00014.html), the
others are all bug fixes.

A follow-up CL will remove all of the exceptions other than 269, but I wanted to
keep the testdata update and the *.go changes separate CLs.

https://codereview.appspot.com/33650044/diff/60001/freetype/truetype/truetype...
freetype/truetype/truetype_test.go:322: continue
On 2013/11/27 13:28:49, bsiegert wrote:
> Should this be an error, or would a warning be better?

This should be an error. It means that the testdata files are corrupted.

[nigeltao, 2013-11-28 03:02:40]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=5c5f2cbdf93a ***

freetype/truetype: upgrade testdata to C Freetype 2.5.1.

R=bsiegert
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/33650044