Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1160)

Issue 336170043: Bidirectional links between Tokyo and N.Virginia

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by Wei Wang
Modified:
1 week, 1 day ago
CC:
brahim Al-Qaysi, zhubiwen509, yulianlluo, farzad2050
Visibility:
Public.

Description

Bidirectional links between Tokyo and N.Virginia Same problem, code review web page cannot show .png Check result here: https://gits-15.sys.kth.se/iaq/WANCom/blob/master/Bidirection_Tokyo_N.Virginia/Result.png

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -0 lines) Patch
A Bidirection_Tokyo_N.Virginia/.DS_Store View Binary file 0 comments Download
A Bidirection_Tokyo_N.Virginia/O-T.png View Binary file 0 comments Download
A Bidirection_Tokyo_N.Virginia/Result.png View Binary file 0 comments Download
A Bidirection_Tokyo_N.Virginia/T-O.png View Binary file 0 comments Download
A Bidirection_Tokyo_N.Virginia/Trace610.xml View 1 chunk +74 lines, -0 lines 0 comments Download
A Bidirection_Tokyo_N.Virginia/index.html View 1 chunk +274 lines, -0 lines 6 comments Download
A Bidirection_Tokyo_N.Virginia/jquery-3.2.1.min.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wei Wang
1 week, 1 day ago (2017-11-14 00:06:27 UTC) #1
manu_chaud
https://codereview.appspot.com/336170043/diff/1/Bidirection_Tokyo_N.Virginia/index.html File Bidirection_Tokyo_N.Virginia/index.html (right): https://codereview.appspot.com/336170043/diff/1/Bidirection_Tokyo_N.Virginia/index.html#newcode98 Bidirection_Tokyo_N.Virginia/index.html:98: /* // HopObj used to store data about each ...
1 week, 1 day ago (2017-11-14 01:56:24 UTC) #2
Wei Wang
1 week, 1 day ago (2017-11-14 09:58:27 UTC) #3
https://codereview.appspot.com/336170043/diff/1/Bidirection_Tokyo_N.Virginia/...
File Bidirection_Tokyo_N.Virginia/index.html (right):

https://codereview.appspot.com/336170043/diff/1/Bidirection_Tokyo_N.Virginia/...
Bidirection_Tokyo_N.Virginia/index.html:98: /*        // HopObj used to store
data about each hop
On 2017/11/14 01:56:24, manu_chaud wrote:
> Can be removed now, don't think we'll ever need it

Sure, I'll delete it in next version.

https://codereview.appspot.com/336170043/diff/1/Bidirection_Tokyo_N.Virginia/...
Bidirection_Tokyo_N.Virginia/index.html:125: /*Paths
On 2017/11/14 01:56:24, manu_chaud wrote:
> Same, may be brushed off

ok

https://codereview.appspot.com/336170043/diff/1/Bidirection_Tokyo_N.Virginia/...
Bidirection_Tokyo_N.Virginia/index.html:173: path: Paths[i],
On 2017/11/14 01:56:24, manu_chaud wrote:
> The problem here, is still the same than before (I hadn't fixed it since I
> didn't work on the file since then, sorry): every iteration of the loop, we
> create a polyline whose points are the ones currently added to the path – so:
> - at the beginning, a line with one point is added, and also I guess 5 lines
> with 0 point, since when we iterate over the first marker, other markers
aren't
> yet added to the Paths object, wherease for each of them a polyline is created
> - second iteration, a line with two points (here, makes sense), + 5 (length fo
> the object Paths - paths which currently contain at least one element (here
only
> the first path, so 1) lines created
> - third, a line with 3 points (so, there will be overlapping)
> - a lot of overlapping...
> 
> For the iterations over the <marker> for path 2, we continue to trace a line
for
>  path 1 (one that go across all its hops, and then the only one that would be
> sufficient!)
> 
> Finally, these redundancies are repeated on the polylines array, which will
> contain a reference for all the lines such created
> 
> Now I understand, I think, why the UI was slow: we create too many lines that
> need to be updated every time the user interacts with the UI...
> 
> I think a solution to that would be to create the polylines after iterating
over
> the markers - might to do it tomorrow after the TA meeting

Got your point. Thanks. Let's fix it after TA meeting.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4