Issue 335810043: [l2tpreg] Made Unicode strings the default and moved PregTool to separate file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 335810043: [l2tpreg] Made Unicode strings the default and moved PregTool to separate file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by Joachim Metz

Modified:
6 years, 6 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

[l2tpreg] Made Unicode strings the default and moved PregTool to separate file

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1376 lines, -1332 lines)			Patch
M	l2tpreg/definitions.py	View	1 chunk	+10 lines, -7 lines	0 comments	Download
M	l2tpreg/front_end.py	View	12 chunks	+40 lines, -38 lines	0 comments	Download
M	l2tpreg/helper.py	View	10 chunks	+27 lines, -25 lines	0 comments	Download
M	l2tpreg/hexdump.py	View	4 chunks	+8 lines, -6 lines	0 comments	Download
M	l2tpreg/plugin_list.py	View	7 chunks	+17 lines, -15 lines	0 comments	Download
A	l2tpreg/preg_tool.py	View	1 chunk	+918 lines, -0 lines	0 comments	Download
M	scripts/preg.py	View	33 chunks	+133 lines, -1032 lines	0 comments	Download
A	tests/preg_tool.py	View	1 chunk	+220 lines, -0 lines	0 comments	Download
M	tests/test_preg.py	View	3 chunks	+3 lines, -209 lines	0 comments	Download

Total messages: 3

Joachim Metz

6 years, 6 months ago (2017-10-20 05:18:14 UTC) #3

merged with https://codereview.appspot.com/336740043/