Issue 335650043: [l2tdevtools] Added auto-generated comment to generated files #279

Issue 335650043: [l2tdevtools] Added auto-generated comment to generated files #279 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 1 month ago by Joachim Metz

Modified:
6 years, 1 month ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[l2tdevtools] Added auto-generated comment to generated files #279

Patch Set 2 : Changed shebang for Python 3 tests #

Patch Set 4 : Changes after review and merge #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -35 lines)			Patch
M	data/msi_prebuild/msi_pysqlite.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	data/templates/.pylintrc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	data/templates/dependencies.py	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download
M	data/templates/runtests.sh	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	l2tdevtools/dependencies.py	View		4 chunks	+20 lines, -15 lines	0 comments	Download
M	run_tests.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/build_helper.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/dependencies.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/download_helper.py	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/dpkg_files.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/presets.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/projects.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/source_helper.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/spec_file.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/update.py	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/build.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dpkg-generate.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/manage.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/msvscpp-convert.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/review.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/stats.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/update.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/update-dependencies.py	View	1 2 3	6 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

onager

I'd like the template message to be a bit more direct, but that's all - ...

6 years, 1 month ago (2018-03-18 09:23:26 UTC) #4

Joachim Metz

https://codereview.appspot.com/335650043/diff/40001/data/templates/.pylintrc File data/templates/.pylintrc (right): https://codereview.appspot.com/335650043/diff/40001/data/templates/.pylintrc#newcode3 data/templates/.pylintrc:3: # This file is generated by l2tdevtools update-dependencies.py On ...

6 years, 1 month ago (2018-03-18 10:11:24 UTC) #5

Joachim Metz

6 years, 1 month ago (2018-03-18 10:13:49 UTC) #7

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close update

Expand All Messages | Collapse All Messages