Issue 335540043: ticket:13571 Switching number parsing code back to incremental code point case folding.

Issue 335540043: ticket:13571 Switching number parsing code back to incremental code point case folding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 2 months ago by sffc

Modified:
6 years, 1 month ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/icu4j/

Visibility:
Public.

More Reviews

Description

ticket:13571 Switching number parsing code back to incremental code point case folding.

Patch Set 1 #

Total comments: 4

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+206 lines, -73 lines)			Patch
M	main/classes/core/src/com/ibm/icu/impl/number/parse/AffixPatternMatcher.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/CodePointMatcher.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/CurrencyMatcher.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/MatcherFactory.java	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/NanMatcher.java	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java	View	12 chunks	+50 lines, -17 lines	2 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/ParsingUtils.java	View	3 chunks	+1 line, -13 lines	0 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/ScientificMatcher.java	View	2 chunks	+8 lines, -16 lines	0 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/StringSegment.java	View	6 chunks	+83 lines, -2 lines	2 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/SymbolMatcher.java	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	main/classes/core/src/com/ibm/icu/impl/number/parse/UnicodeSetStaticCache.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	main/tests/core/src/com/ibm/icu/dev/test/format/MeasureUnitTest.java	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	main/tests/core/src/com/ibm/icu/dev/test/number/NumberParserTest.java	View	3 chunks	+37 lines, -1 line	0 comments	Download
M	main/tests/core/src/com/ibm/icu/dev/test/number/StringSegmentTest.java	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andy.heninger

Two minor comments, otherwise looks good. https://codereview.appspot.com/335540043/diff/1/main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java File main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java (right): https://codereview.appspot.com/335540043/diff/1/main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java#newcode35 main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java:35: public static NumberParserImpl ...

6 years, 2 months ago (2018-02-20 20:39:58 UTC) #2

sffc

6 years, 1 month ago (2018-03-01 01:05:16 UTC) #3

https://codereview.appspot.com/335540043/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java
(right):

https://codereview.appspot.com/335540043/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java:35:
public static NumberParserImpl removeMeWhenMerged(ULocale locale, String
pattern, int parseFlags) {
On 2018/02/20 20:39:58, andy.heninger wrote:
> Maybe add a comment explaining what's going on, what is being merged

Acknowledged.  It's too hard to change this function now since my branch and the
trunk are out of sync.

https://codereview.appspot.com/335540043/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/number/parse/StringSegment.java
(right):

https://codereview.appspot.com/335540043/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/number/parse/StringSegment.java:150: //
TODO: case-fold code points, not chars
On 2018/02/20 20:39:58, andy.heninger wrote:
> This ought to be fixed. It's trivial to do so. If you get two supplementals,
the
> lead surrogate will most likely match.

Fixed this in r41003.

Expand All Messages | Collapse All Messages