Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(106)

Issue 335150043: Refreshing Number Parsing: ICU4J

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 2 weeks ago by sffc
Modified:
7 months ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

http://bugs.icu-project.org/trac/ticket/13513

Patch Set 1 #

Patch Set 2 : Adding AffixMatcher and SymbolMatcher. AffixMatcher favors longer affixes over shorter ones. Not … #

Patch Set 3 : Cleaning up code. Adding a few more test cases for the AffixMatcher. #

Patch Set 4 : Adding a matcher for scientific notation. Renamed MantissaMatcher -> DecimalMatcher. #

Patch Set 5 : Adding currency matcher. #

Patch Set 6 : Resetting file version history to new branch. #

Total comments: 6

Patch Set 7 : Starting to tie in with upstream. #

Total comments: 1

Patch Set 8 : Most of the way through the data-driven file. Still thinking about how to handle a few strange case… #

Patch Set 9 : Re-thinking affix matchers a bit. Affix matchers now contain only regular characters, not symbols. #

Patch Set 10 : Data-driven unit tests are passing. #

Total comments: 7

Patch Set 11 : Replying to Andy feedback round one. See commit message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8906 lines, -4941 lines) Patch
A . View 1 2 3 4 5 6 7 8 9 10 0 chunks +0 lines, -0 lines 0 comments Download
M .gitignore View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
A icu4c View 1 2 3 4 5 6 7 8 9 10 0 chunks +0 lines, -0 lines 0 comments Download
A icu4c/source View 1 2 3 4 5 6 7 8 9 10 0 chunks +0 lines, -0 lines 0 comments Download
M icu4c/source/common/rbbi.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -6 lines 0 comments Download
M icu4c/source/common/rbbidata.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +7 lines, -4 lines 0 comments Download
M icu4c/source/common/rbbitblb.cpp View 1 2 3 4 5 6 7 8 9 10 3 chunks +6 lines, -9 lines 0 comments Download
M icu4c/source/common/ucmndata.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -1 line 0 comments Download
M icu4c/source/common/ucmndata.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -1 line 0 comments Download
M icu4c/source/common/ustr_wcs.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/Makefile.in View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
A icu4c/source/i18n/currdisplayinfo.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
A icu4c/source/i18n/currdisplayinfo.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +79 lines, -0 lines 0 comments Download
M icu4c/source/i18n/decimalformatpattern.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +6 lines, -4 lines 0 comments Download
M icu4c/source/i18n/i18n.vcxproj View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/i18n.vcxproj.filters View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
M icu4c/source/i18n/measfmt.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -4 lines 0 comments Download
M icu4c/source/i18n/measunit.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +7 lines, -4 lines 0 comments Download
M icu4c/source/i18n/number_affixutils.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/number_fluent.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +19 lines, -0 lines 0 comments Download
M icu4c/source/i18n/number_formatimpl.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/number_longnames.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -2 lines 0 comments Download
M icu4c/source/i18n/number_longnames.cpp View 1 2 3 4 5 6 7 8 9 10 8 chunks +125 lines, -23 lines 0 comments Download
M icu4c/source/i18n/number_rounding.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +28 lines, -16 lines 0 comments Download
M icu4c/source/i18n/number_types.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +11 lines, -0 lines 0 comments Download
M icu4c/source/i18n/unicode/decimfmt.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M icu4c/source/i18n/unicode/measunit.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M icu4c/source/i18n/unicode/nounit.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -5 lines 0 comments Download
M icu4c/source/i18n/unicode/numberformatter.h View 1 2 3 4 5 6 7 8 9 10 7 chunks +69 lines, -6 lines 0 comments Download
A icu4c/source/test View 1 2 3 4 5 6 7 8 9 10 0 chunks +0 lines, -0 lines 0 comments Download
A icu4c/source/test/intltest View 1 2 3 4 5 6 7 8 9 10 0 chunks +0 lines, -0 lines 0 comments Download
M icu4c/source/test/intltest/numbertest.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -0 lines 0 comments Download
M icu4c/source/test/intltest/numbertest_api.cpp View 1 2 3 4 5 6 7 8 9 10 13 chunks +69 lines, -28 lines 0 comments Download
M icu4c/source/test/intltest/ucdtest.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/test/intltest/ucdtest.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +19 lines, -0 lines 0 comments Download
A icu4j View 1 2 3 4 5 6 7 8 9 10 0 chunks +0 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/.externalToolBuilders/copy-data-core.launch View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M icu4j/main/classes/core/.settings/org.eclipse.jdt.core.prefs View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -261 lines 0 comments Download
M icu4j/main/classes/core/.settings/org.eclipse.jdt.ui.prefs View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -2 lines 0 comments Download
M icu4j/main/classes/core/core-build.launch View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -3 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/TextTrieMap.java View 1 2 3 4 5 6 7 8 9 10 8 chunks +53 lines, -12 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/AffixPatternProvider.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +21 lines, -13 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/AffixUtils.java View 1 2 3 4 5 6 7 8 9 10 2 chunks +599 lines, -517 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/CompactData.java View 1 2 3 4 5 6 7 8 9 10 4 chunks +15 lines, -5 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/ConstantAffixModifier.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/ConstantMultiFieldModifier.java View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -4 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/CurrencyPluralInfoAffixProvider.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +64 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/CurrencySpacingEnabledModifier.java View 1 2 3 4 5 6 7 8 9 10 6 chunks +27 lines, -10 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/CustomSymbolCurrency.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +54 lines, -55 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/DecimalFormatProperties.java View 1 2 3 4 5 6 7 8 9 10 43 chunks +173 lines, -143 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/DecimalQuantity.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +156 lines, -135 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/DecimalQuantity_AbstractBCD.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +884 lines, -787 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/DecimalQuantity_DualStorageBCD.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +374 lines, -353 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/LongNameHandler.java View 1 2 3 4 5 6 7 8 9 10 9 chunks +156 lines, -33 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/MacroProps.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +105 lines, -83 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/MicroProps.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/MicroPropsGenerator.java View 1 2 3 4 5 6 7 8 9 10 2 chunks +13 lines, -10 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/Modifier.java View 1 2 3 4 5 6 7 8 9 10 3 chunks +14 lines, -13 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/MultiplierImpl.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +29 lines, -29 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/MultiplierProducer.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +9 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/MutablePatternModifier.java View 1 2 3 4 5 6 7 8 9 10 15 chunks +61 lines, -43 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/NumberStringBuilder.java View 1 2 3 4 5 6 7 8 9 10 11 chunks +42 lines, -19 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/Padder.java View 1 2 3 4 5 6 7 8 9 10 3 chunks +39 lines, -33 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/ParameterizedModifier.java View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -4 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/PatternStringParser.java View 1 2 3 4 5 6 7 8 9 10 11 chunks +35 lines, -18 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/PatternStringUtils.java View 1 2 3 4 5 6 7 8 9 10 5 chunks +21 lines, -13 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/Properties.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/PropertiesAffixPatternProvider.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +131 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +165 lines, -149 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/SimpleModifier.java View 1 2 3 4 5 6 7 8 9 10 4 chunks +18 lines, -9 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/AffixMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +218 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/CurrencyMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +72 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/CurrencyTrieMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +72 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/DecimalMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +311 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/IgnorablesMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +55 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/InfinityMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +49 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/MinusSignMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +49 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/MultiplierHandler.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +41 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/NanMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +63 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParseMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +44 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +389 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/PaddingMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +36 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ParsedNumber.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +149 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ParsingUtils.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +53 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/PercentMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +57 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/PermilleMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +57 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/PlusSignMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +49 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/RangeMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +63 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/RequireAffixMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +26 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/RequireCurrencyMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +25 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/RequireDecimalSeparatorMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +24 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/RequireExponentMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +25 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/RequireNumberMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +26 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ScientificMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +108 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/StringSegment.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +102 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/SymbolMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +77 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/UnicodeSetStaticCache.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +210 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ValidationMatcher.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +24 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/CompactNotation.java View 1 2 3 4 5 6 7 8 9 10 3 chunks +19 lines, -8 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/CurrencyRounder.java View 1 2 3 4 5 6 7 8 9 10 2 chunks +7 lines, -7 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/FractionRounder.java View 1 2 3 4 5 6 7 8 9 10 4 chunks +22 lines, -19 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/Grouper.java View 1 2 3 4 5 6 7 8 9 10 3 chunks +45 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/IntegerWidth.java View 1 2 3 4 5 6 7 8 9 10 4 chunks +13 lines, -9 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/LocalizedNumberFormatter.java View 1 2 3 4 5 6 7 8 9 10 5 chunks +13 lines, -12 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/Notation.java View 1 2 3 4 5 6 7 8 9 10 7 chunks +33 lines, -25 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatter.java View 1 2 3 4 5 6 7 8 9 10 19 chunks +64 lines, -53 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatterImpl.java View 1 2 3 4 5 6 7 8 9 10 13 chunks +66 lines, -33 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatterSettings.java View 1 2 3 4 5 6 7 8 9 10 15 chunks +71 lines, -32 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/NumberPropertyMapper.java View 1 2 3 4 5 6 7 8 9 10 14 chunks +34 lines, -204 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/Rounder.java View 1 2 3 4 5 6 7 8 9 10 17 chunks +143 lines, -89 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/ScientificNotation.java View 1 2 3 4 5 6 7 8 9 10 7 chunks +35 lines, -20 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/SimpleNotation.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/UnlocalizedNumberFormatter.java View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -3 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/DecimalFormat.java View 1 2 3 4 5 6 7 8 9 10 9 chunks +57 lines, -30 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/DictionaryBreakEngine.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/TimeZoneFormat.java View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -6 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java View 1 2 3 4 5 6 7 8 9 10 3 chunks +12 lines, -3 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/util/MeasureUnit.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M icu4j/main/tests/core/.settings/org.eclipse.jdt.core.prefs View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -259 lines 0 comments Download
M icu4j/main/tests/core/.settings/org.eclipse.jdt.ui.prefs View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -3 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/data/numberformattestspecification.txt View 1 2 3 4 5 6 7 8 9 10 16 chunks +56 lines, -52 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatDataDrivenTest.java View 1 2 3 4 5 6 7 8 9 10 7 chunks +108 lines, -2 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java View 1 2 3 4 5 6 7 8 9 10 22 chunks +51 lines, -36 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/lang/UCharacterCaseTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +22 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/AffixUtilsTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +185 lines, -172 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/DecimalQuantityTest.java View 1 2 3 4 5 6 7 8 9 10 2 chunks +453 lines, -422 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/ModifierTest.java View 1 2 3 4 5 6 7 8 9 10 6 chunks +42 lines, -20 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/MutablePatternModifierTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -2 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java View 1 2 3 4 5 6 7 8 9 10 5 chunks +164 lines, -0 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberParserTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +118 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberStringBuilderTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +172 lines, -173 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/PatternStringTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +95 lines, -86 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/PropertiesTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +293 lines, -274 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/StringSegmentTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +99 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +60 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/util/TextTrieMapTest.java View 1 2 3 4 5 6 7 8 9 10 5 chunks +52 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/impl/number/DecimalQuantity_SimpleStorage.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16
sffc
8 months, 2 weeks ago (2017-12-07 08:50:29 UTC) #1
sffc
Adding AffixMatcher and SymbolMatcher. AffixMatcher favors longer affixes over shorter ones. Not all possible features ...
8 months, 2 weeks ago (2017-12-08 09:12:23 UTC) #2
sffc
Uploaded today's work.
8 months, 2 weeks ago (2017-12-08 09:13:02 UTC) #3
sffc
Cleaning up code. Adding a few more test cases for the AffixMatcher.
8 months, 1 week ago (2017-12-12 06:35:28 UTC) #4
sffc
Adding a matcher for scientific notation. Renamed MantissaMatcher -> DecimalMatcher.
8 months, 1 week ago (2017-12-12 09:32:16 UTC) #5
sffc
More features added and code cleaned up a bit. Please take another look. Still need ...
8 months, 1 week ago (2017-12-12 11:48:45 UTC) #6
sffc
Adding currency matcher.
8 months, 1 week ago (2017-12-13 04:26:55 UTC) #7
sffc
Resetting file version history to new branch.
8 months, 1 week ago (2017-12-13 05:06:19 UTC) #8
sffc
Updating base of code to new branch. https://codereview.appspot.com/335150043/diff/100001/main/classes/core/.externalToolBuilders/copy-data-core.launch File main/classes/core/.externalToolBuilders/copy-data-core.launch (left): https://codereview.appspot.com/335150043/diff/100001/main/classes/core/.externalToolBuilders/copy-data-core.launch#oldcode1 main/classes/core/.externalToolBuilders/copy-data-core.launch:1: <?xml version="1.0" ...
8 months, 1 week ago (2017-12-13 05:08:48 UTC) #9
sffc
My branch is here: http://source.icu-project.org/repos/icu/branches/shane/numberformat3/
8 months, 1 week ago (2017-12-13 10:05:13 UTC) #10
sffc
Starting to tie in with upstream.
8 months, 1 week ago (2017-12-13 10:07:57 UTC) #11
sffc
Most of the way through the data-driven file. Still thinking about how to handle a ...
8 months, 1 week ago (2017-12-14 10:28:18 UTC) #12
sffc
Re-thinking affix matchers a bit. Affix matchers now contain only regular characters, not symbols.
8 months, 1 week ago (2017-12-15 00:16:27 UTC) #13
sffc
Data-driven unit tests are passing.
8 months ago (2017-12-16 10:08:15 UTC) #14
andy.heninger
https://codereview.appspot.com/335150043/diff/120001/main/classes/core/src/com/ibm/icu/impl/number/parse/StringSegment.java File main/classes/core/src/com/ibm/icu/impl/number/parse/StringSegment.java (right): https://codereview.appspot.com/335150043/diff/120001/main/classes/core/src/com/ibm/icu/impl/number/parse/StringSegment.java#newcode27 main/classes/core/src/com/ibm/icu/impl/number/parse/StringSegment.java:27: assert start <= end; For a class like this, ...
7 months ago (2018-01-17 02:00:13 UTC) #15
sffc
7 months ago (2018-01-18 11:03:14 UTC) #16
Replying to Andy feedback round one. See commit message.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b