Issue 334860043: all DB code commented

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 334860043: all DB code commented

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by paul.busi38

Modified:
6 years, 4 months ago

Reviewers:
engr.sikandar.iqbal, Vasileios Papageorgiou, dkostic, younes.tahri3, michail.xirouchakis, alireza.farshin

CC:
sdnik2200ht17_ict.kth.se

Visibility:
Public.

More Reviews

Description

all DB code commented BUG= code with comments

Patch Set 1 #

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -62 lines)			Patch
M	DB/API_REST/config.php	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	DB/API_REST/daemon_DB.sh	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	DB/API_REST/mem_connect.php	View	1 chunk	+9 lines, -4 lines	1 comment	Download
M	DB/API_REST/print_cache.php	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	DB/API_REST/request.php	View	1 chunk	+72 lines, -31 lines	2 comments	Download
M	DB/API_REST/thread_database.php	View	5 chunks	+35 lines, -16 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Vasileios Papageorgiou

Hi Paul see the comment for memcache! Thanks! Vasilis https://codereview.appspot.com/334860043/diff/1/DB/API_REST/mem_connect.php File DB/API_REST/mem_connect.php (right): https://codereview.appspot.com/334860043/diff/1/DB/API_REST/mem_connect.php#newcode6 DB/API_REST/mem_connect.php:6: ...

6 years, 6 months ago (2017-10-18 09:19:48 UTC) #1

Vasileios Papageorgiou

Hi, Nice comments on the request.php BR, Vasileios Papageorgiou https://codereview.appspot.com/334860043/diff/1/DB/API_REST/request.php File DB/API_REST/request.php (right): https://codereview.appspot.com/334860043/diff/1/DB/API_REST/request.php#newcode120 DB/API_REST/request.php:120: ...

6 years, 6 months ago (2017-10-18 09:51:44 UTC) #2

younes.tahri3

6 years, 4 months ago (2017-12-06 14:20:07 UTC) #3

https://codereview.appspot.com/334860043/diff/1/DB/API_REST/request.php
File DB/API_REST/request.php (right):

https://codereview.appspot.com/334860043/diff/1/DB/API_REST/request.php#newco...
DB/API_REST/request.php:35: $type=2; //if there is a field named port_counters,
the Json object type is 2
I think you meant flow_counters here in your comment

https://codereview.appspot.com/334860043/diff/1/DB/API_REST/thread_database.php
File DB/API_REST/thread_database.php (right):

https://codereview.appspot.com/334860043/diff/1/DB/API_REST/thread_database.p...
DB/API_REST/thread_database.php:131: //same principle as for port counters
I think you meant HUM metrics here

Expand All Messages | Collapse All Messages