Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(756)

Issue 334860043: all DB code commented

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 3 weeks ago by paul.busi38
Modified:
5 days ago
CC:
sdnik2200ht17_ict.kth.se
Visibility:
Public.

Description

all DB code commented BUG= code with comments

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -62 lines) Patch
M DB/API_REST/config.php View 1 chunk +4 lines, -1 line 0 comments Download
M DB/API_REST/daemon_DB.sh View 2 chunks +8 lines, -6 lines 0 comments Download
M DB/API_REST/mem_connect.php View 1 chunk +9 lines, -4 lines 1 comment Download
M DB/API_REST/print_cache.php View 1 chunk +4 lines, -4 lines 0 comments Download
M DB/API_REST/request.php View 1 chunk +72 lines, -31 lines 2 comments Download
M DB/API_REST/thread_database.php View 5 chunks +35 lines, -16 lines 1 comment Download

Messages

Total messages: 3
Vasileios Papageorgiou
Hi Paul see the comment for memcache! Thanks! Vasilis https://codereview.appspot.com/334860043/diff/1/DB/API_REST/mem_connect.php File DB/API_REST/mem_connect.php (right): https://codereview.appspot.com/334860043/diff/1/DB/API_REST/mem_connect.php#newcode6 DB/API_REST/mem_connect.php:6: ...
1 month, 3 weeks ago (2017-10-18 09:19:48 UTC) #1
Vasileios Papageorgiou
Hi, Nice comments on the request.php BR, Vasileios Papageorgiou https://codereview.appspot.com/334860043/diff/1/DB/API_REST/request.php File DB/API_REST/request.php (right): https://codereview.appspot.com/334860043/diff/1/DB/API_REST/request.php#newcode120 DB/API_REST/request.php:120: ...
1 month, 3 weeks ago (2017-10-18 09:51:44 UTC) #2
younes.tahri3
5 days ago (2017-12-06 14:20:07 UTC) #3
https://codereview.appspot.com/334860043/diff/1/DB/API_REST/request.php
File DB/API_REST/request.php (right):

https://codereview.appspot.com/334860043/diff/1/DB/API_REST/request.php#newco...
DB/API_REST/request.php:35: $type=2; //if there is a field named port_counters,
the Json object type is 2
I think you meant flow_counters here in your comment

https://codereview.appspot.com/334860043/diff/1/DB/API_REST/thread_database.php
File DB/API_REST/thread_database.php (right):

https://codereview.appspot.com/334860043/diff/1/DB/API_REST/thread_database.p...
DB/API_REST/thread_database.php:131: //same principle as for port counters
I think you meant HUM metrics here
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d