This is an endpoint that will be useful for inlining and for supporting safe dynamic script tags and iframes. Given a url, the end point returns santized html, cajoled js and lint messages and errors.
Submitted @1043815
15 years, 11 months ago
(2010-12-02 18:56:09 UTC)
#3
snapshot
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java
(right):
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java:537:
this.debug= getBooleanParam(request, "debug");
On 2010/11/29 20:35:25, johnfargo wrote:
> supernit: space before =
Done.
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
(right):
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:188:
public List<String> getDirectives();
As suggested, the directives are nuked. The distinction between cajita and
valija is going away to be replaced with just ES53.
On 2010/11/29 20:35:25, johnfargo wrote:
> (I'll probably see in the next file or two)
> What are these directives? General purpose question, any value in making this
> more well-structured?
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:194:
public List<String> getMessages();
On 2010/11/29 20:35:25, johnfargo wrote:
> FMI any better structure we can provide to this? Specifically:
> * Type [lint, error, warning, etc]
> * Line # info
Done. Exposed the structured information that we have.
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
(right):
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:267:
throw new ProcessingException("Missing container paramater",
HttpResponse.SC_BAD_REQUEST);
On 2010/11/29 20:35:25, johnfargo wrote:
> s/paramater/parameter/
Done.
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:274:
}
On 2010/11/29 20:35:25, johnfargo wrote:
> all these 3 checks could just use verifyBaseParams(request, true)
Done.
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:281:
request.getMimeType(), !request.getDirectives().contains("valija"),
request.getDebug());
On 2010/11/29 20:35:25, johnfargo wrote:
> My understanding is that the cajita/valija distinction is going away, and
sooner
> than later. Assuming this is so, we should just get rid of this directive's
> support.
Done.
http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java File java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java (right): http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java#newcode211 java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java:211: EasyMock.anyBoolean(), It is. I was unsure of test convention ...
15 years, 11 months ago
(2010-12-02 19:31:20 UTC)
#5
Dunno personally if there's a hard-and-fast rule on this convention; I have a minor personal ...
15 years, 11 months ago
(2010-12-02 19:34:01 UTC)
#6
Dunno personally if there's a hard-and-fast rule on this convention; I have
a minor personal preference to fix it at true to ensure we're always on ES53
w/r/t to the Caja API.
On Thu, Dec 2, 2010 at 11:31 AM, <jasvir@gmail.com> wrote:
>
>
>
http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/or...
> File
>
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
> (right):
>
>
>
http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/or...
>
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java:211:
> EasyMock.anyBoolean(),
> It is. I was unsure of test convention - the particular test would hold
> even if those were false though which is why I went with anyBoolean.
>
> Happy to change it.
>
> On 2010/12/02 19:23:05, johnfargo wrote:
>
>> isn't this always "true"?
>>
>
> http://codereview.appspot.com/3348041/
>
Dunno personally if there's a hard-and-fast rule on this convention; I have a minor personal ...
15 years, 11 months ago
(2010-12-02 19:35:50 UTC)
#7
Dunno personally if there's a hard-and-fast rule on this convention; I have
a minor personal preference to fix it at true to ensure we're always on ES53
w/r/t to the Caja API.
On Thu, Dec 2, 2010 at 11:31 AM, <jasvir@gmail.com> wrote:
>
>
>
http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/or...
> File
>
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
> (right):
>
>
>
http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/or...
>
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java:211:
> EasyMock.anyBoolean(),
> It is. I was unsure of test convention - the particular test would hold
> even if those were false though which is why I went with anyBoolean.
>
> Happy to change it.
>
> On 2010/12/02 19:23:05, johnfargo wrote:
>
>> isn't this always "true"?
>>
>
> http://codereview.appspot.com/3348041/
>
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode159 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:159: CharProducer cp = fetcher.fetch(extRef, mime).getTextualContent(); Do we care about ...
15 years, 11 months ago
(2010-12-02 21:23:13 UTC)
#8
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode159 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:159: CharProducer cp = fetcher.fetch(extRef, mime).getTextualContent(); If the fetch fails, ...
15 years, 11 months ago
(2010-12-08 22:54:58 UTC)
#9
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:159:
CharProducer cp = fetcher.fetch(extRef, mime).getTextualContent();
If the fetch fails, the failure is reported as part of the serialization of the
message queue. Added a comment to that effect.
On 2010/12/02 21:23:13, zhoresh wrote:
> Do we care about response code or any other header information (encoding?)
> Do we care if fetch failed?
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:297:
@VisibleForTesting
Reverted.
On 2010/12/02 21:23:13, zhoresh wrote:
> Did you create more tests that are not attached?
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java
(right):
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java:82:
private static final List<String> DEFAULT_CAJA_FIELDS = ImmutableList.of("html",
"js", "messages");
On 2010/12/02 21:23:13, zhoresh wrote:
> Just use "*" :)
Done.
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
(right):
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:187:
public boolean getDebug();
As the CL stands, no caching is done. Marked this as TODO.
On 2010/12/02 21:23:13, zhoresh wrote:
> Not sure who is the user but I can see for consistency to support also
> getIgnoreCache() and getRefresh()
> (maybe add a comment that indicate the base url is used for the resource to
> cajoled)
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
(right):
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:105:
.put(GadgetsHandlerApi.RenderingContext.class, RenderingContext.class)
See below.
On 2010/12/02 21:23:13, zhoresh wrote:
> To support validation add
> .put(CajaMessageLevel.class, GadgetHandlerApi.MessageLevel.class)
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:287:
m.format(mc), convertMessageLevel(m.getMessageLevel().name()));
I ran into errors using beanDelegator the way you suggest. I've marked this as
a TODO.
On 2010/12/02 21:23:13, zhoresh wrote:
> You can use beanDelegator to do this conversion which will also give a test
> failure if the enums don't match.
> beanDelegator(m.getMessageLevel(), GadgetHandlerApi.MessageLevel.class, null)
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:325:
timeSource.currentTimeMillis() + specRefreshInterval);
On 2010/12/02 21:23:13, zhoresh wrote:
> Do you really want the same expiration logic as gadget spec?
> I would think that the proxy expiration logic would be better (use
HttpResponse
> expiration time).
> You can put a TODO for later improvement.
Done.
Issue 3348041: Expose a cajoling service end point
(Closed)
Created 15 years, 11 months ago by Jasvir
Modified 15 years, 11 months ago
Reviewers: zhoresh, johnfargo, fargo
Base URL: https://svn.apache.org/repos/asf/shindig/trunk/
Comments: 40