Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 3348041: Expose a cajoling service end point (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 11 months ago by Jasvir
Modified:
15 years, 11 months ago
Reviewers:
johnfargo, zhoresh, fargo
CC:
shindig.remailer_gmail.com
Base URL:
https://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This is an endpoint that will be useful for inlining and for supporting safe dynamic script tags and iframes. Given a url, the end point returns santized html, cajoled js and lint messages and errors. Submitted @1043815

Patch Set 1 #

Total comments: 12

Patch Set 2 : Incorporating review suggestions #

Total comments: 3

Patch Set 3 : Unused directive in api removed #

Total comments: 15

Patch Set 4 : Snapshot to head and addressed comments #

Total comments: 10

Patch Set 5 : minor fixes #

Messages

Total messages: 11
Jasvir
15 years, 11 months ago (2010-11-29 20:12:55 UTC) #1
johnfargo
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java (right): http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java#newcode537 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java:537: this.debug= getBooleanParam(request, "debug"); supernit: space before = http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java File ...
15 years, 11 months ago (2010-11-29 20:35:24 UTC) #2
Jasvir
snapshot http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java (right): http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java#newcode537 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java:537: this.debug= getBooleanParam(request, "debug"); On 2010/11/29 20:35:25, johnfargo wrote: ...
15 years, 11 months ago (2010-12-02 18:56:09 UTC) #3
johnfargo
LGTM++ Nits http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java (right): http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java#newcode268 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:268: public static enum Directive { unused? http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java ...
15 years, 11 months ago (2010-12-02 19:23:04 UTC) #4
Jasvir
http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java File java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java (right): http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java#newcode211 java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java:211: EasyMock.anyBoolean(), It is. I was unsure of test convention ...
15 years, 11 months ago (2010-12-02 19:31:20 UTC) #5
fargo
Dunno personally if there's a hard-and-fast rule on this convention; I have a minor personal ...
15 years, 11 months ago (2010-12-02 19:34:01 UTC) #6
fargo
Dunno personally if there's a hard-and-fast rule on this convention; I have a minor personal ...
15 years, 11 months ago (2010-12-02 19:35:50 UTC) #7
zhoresh
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode159 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:159: CharProducer cp = fetcher.fetch(extRef, mime).getTextualContent(); Do we care about ...
15 years, 11 months ago (2010-12-02 21:23:13 UTC) #8
Jasvir
http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode159 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:159: CharProducer cp = fetcher.fetch(extRef, mime).getTextualContent(); If the fetch fails, ...
15 years, 11 months ago (2010-12-08 22:54:58 UTC) #9
johnfargo
LGTM http://codereview.appspot.com/3348041/diff/26001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/3348041/diff/26001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode99 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:99: private static final String classname = "org.apache.shindig.gadgets.servlet.CajaContentRewriter"; reason ...
15 years, 11 months ago (2010-12-09 01:20:30 UTC) #10
Jasvir
15 years, 11 months ago (2010-12-09 01:52:03 UTC) #11
snapshot

http://codereview.appspot.com/3348041/diff/26001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/3348041/diff/26001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:99:
private static final String classname =
"org.apache.shindig.gadgets.servlet.CajaContentRewriter";
Weird - I don't remember seeing that before.  Fixed.

On 2010/12/09 01:20:30, johnfargo wrote:
> reason you don't use CajaContentRewriter.class.getName()?

http://codereview.appspot.com/3348041/diff/26001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:116:
LOG.logp(Level.INFO, classname, "CajaContentRewriter",
MessageKeys.CAJOLED_CACHE_CREATED, new Object[] {cajoledCache});
On 2010/12/09 01:20:30, johnfargo wrote:
> >100char

Done.

http://codereview.appspot.com/3348041/diff/26001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:310:
LOG.logp(Level.INFO, classname, "makeFetcher", MessageKeys.RETRIEVE_REFERENCE,
new Object[] {ref.toString()});
On 2010/12/09 01:20:30, johnfargo wrote:
> >100char

Done.

http://codereview.appspot.com/3348041/diff/26001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:322:
LOG.logp(Level.INFO, classname, "makeFetcher", MessageKeys.FAILED_TO_RETRIEVE,
new Object[] {ref.toString()});
On 2010/12/09 01:20:30, johnfargo wrote:
> >100char

Done.

http://codereview.appspot.com/3348041/diff/26001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:327:
LOG.logp(Level.INFO, classname, "makeFetcher", MessageKeys.FAILED_TO_READ, new
Object[] {ref.toString()});
On 2010/12/09 01:20:30, johnfargo wrote:
> >100char

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b