Issue 334750043: ICU ticket #13384: Fixes issue described in comment2 (strcase.cpp excluded) in #13384: adjust code …

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by nrunge

Modified:
6 years, 6 months ago

Reviewers:
andy.heninger, aheninger, markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/icu4c/

Visibility:
Public.

ICU ticket #13384: Fixes issue described in comment2 (strcase.cpp excluded) in #13384: adjust code …

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
M	source/common/rbbi_cache.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	source/common/rbbi_cache.cpp	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	source/common/unicode/uconfig.h	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	source/i18n/unicode/dtptngen.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	source/test/intltest/loctest.cpp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	source/test/intltest/rbbitst.cpp	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5

nrunge

ticket 13384: dtptngen.h requires #include "unicode/unistr.h.

6 years, 6 months ago (2017-10-06 16:35:03 UTC) #3

LGTM