Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(243)

Issue 334740043: Merge_rests_engraver: fix vertical rest positions

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Malte Meyn
Modified:
6 years, 5 months ago
Reviewers:
dak, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Merge_rests_engraver: fix vertical rest positions When used with \magnifyStaff the engraver failed to position merged rests correctly. Using staff-position instead of Y-offset for vertical positioning fixes this.

Patch Set 1 #

Total comments: 2

Patch Set 2 : cleaner solution, added regtests #

Patch Set 3 : replace moment=? by equal? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -48 lines) Patch
M input/regression/merge-rests-engraver.ly View 1 3 chunks +8 lines, -1 line 0 comments Download
A input/regression/merge-rests-magnify-staff.ly View 1 1 chunk +28 lines, -0 lines 0 comments Download
M scm/scheme-engravers.scm View 1 2 2 chunks +31 lines, -47 lines 0 comments Download

Messages

Total messages: 10
Malte Meyn
See https://lists.gnu.org/archive/html/lilypond-user/2017-10/msg00012.html for sort of bug report on the user list.
6 years, 5 months ago (2017-10-04 15:03:01 UTC) #1
thomasmorley651
Hi Malte, your patch fixes the "magnifyStaff"-problem. Though, this functionality needs testing, imho. I'd extend ...
6 years, 5 months ago (2017-10-05 20:48:14 UTC) #2
Malte Meyn
Thanks for the suggestions, I’ll apply these fixes, test them, and add a regression test. ...
6 years, 5 months ago (2017-10-06 08:12:23 UTC) #3
dak
On 2017/10/06 08:12:23, Malte Meyn wrote: > Thanks for the suggestions, I’ll apply these fixes, ...
6 years, 5 months ago (2017-10-06 08:19:46 UTC) #4
Malte Meyn
On 2017/10/06 08:19:46, dak wrote: > Stupid question: is there no way to (re-)use the ...
6 years, 5 months ago (2017-10-06 08:42:55 UTC) #5
Malte Meyn
On 2017/10/06 08:42:55, Malte Meyn wrote: > But there’s this little inconsistency: > > { ...
6 years, 5 months ago (2017-10-06 08:45:27 UTC) #6
dak
On 2017/10/06 08:42:55, Malte Meyn wrote: > On 2017/10/06 08:19:46, dak wrote: > > Stupid ...
6 years, 5 months ago (2017-10-06 09:39:11 UTC) #7
Malte Meyn
cleaner solution, added regtests
6 years, 5 months ago (2017-10-06 21:04:42 UTC) #8
Malte Meyn
On 2017/10/06 09:39:11, dak wrote: > I mean exactly what I say: set direction to ...
6 years, 5 months ago (2017-10-06 21:18:02 UTC) #9
Malte Meyn
6 years, 5 months ago (2017-10-07 11:16:59 UTC) #10
replace moment=? by equal?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b