Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1403)

Issue 334510043: Issue 5275: Avoid duplicate rehearsal marks in regression tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by Dan Eble
Modified:
1 year, 8 months ago
Reviewers:
Malte Meyn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5275/ Having multiple marks with the same sequence number is something that LilyPond might reasonably warn about in a future version. I suppose LilyPond might reasonably warn about out-of-sequence marks, but I haven't gone that far with this. Let me know if you think I should.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix expected value in test description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M input/regression/rehearsal-mark-formatters.ly View 1 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3
Dan Eble
Malte, This patch changes a regression test you committed in January. I think it still ...
1 year, 9 months ago (2018-02-18 13:51:40 UTC) #1
Malte Meyn
I see arguments both for and against such warnings. • maybe CON, depending on the ...
1 year, 9 months ago (2018-02-20 16:28:21 UTC) #2
Dan Eble
1 year, 9 months ago (2018-02-20 17:52:47 UTC) #3
Fix expected value in test description
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b