Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5446)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 334500043: [dfvfs] Changed file entry type to public attribute #52 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Joachim Metz
Modified:
6 years, 2 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Changed file entry type to public attribute #52

Patch Set 1 : Changed file entry type to public attribute #52 #

Total comments: 4

Patch Set 2 : Changes after review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -81 lines) Patch
M dfvfs/lib/definitions.py View 1 chunk +6 lines, -6 lines 0 comments Download
M dfvfs/vfs/bde_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/vfs/compressed_stream_file_entry.py View 2 chunks +2 lines, -2 lines 0 comments Download
M dfvfs/vfs/cpio_file_entry.py View 3 chunks +8 lines, -8 lines 0 comments Download
M dfvfs/vfs/encoded_stream_file_entry.py View 2 chunks +2 lines, -2 lines 0 comments Download
M dfvfs/vfs/encrypted_stream_file_entry.py View 2 chunks +2 lines, -2 lines 0 comments Download
M dfvfs/vfs/fake_file_entry.py View 2 chunks +2 lines, -2 lines 0 comments Download
M dfvfs/vfs/file_entry.py View 1 9 chunks +24 lines, -16 lines 2 comments Download
M dfvfs/vfs/fvde_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/vfs/gzip_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/vfs/lvm_file_entry.py View 2 chunks +3 lines, -3 lines 0 comments Download
M dfvfs/vfs/ntfs_file_entry.py View 1 chunk +3 lines, -3 lines 0 comments Download
M dfvfs/vfs/os_file_entry.py View 3 chunks +8 lines, -8 lines 0 comments Download
M dfvfs/vfs/sqlite_blob_file_entry.py View 2 chunks +3 lines, -3 lines 0 comments Download
M dfvfs/vfs/tar_file_entry.py View 2 chunks +6 lines, -6 lines 0 comments Download
M dfvfs/vfs/tsk_file_entry.py View 3 chunks +8 lines, -8 lines 0 comments Download
M dfvfs/vfs/tsk_partition_file_entry.py View 2 chunks +3 lines, -3 lines 0 comments Download
M dfvfs/vfs/vshadow_file_entry.py View 2 chunks +3 lines, -3 lines 0 comments Download
M dfvfs/vfs/zip_file_entry.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9
Joachim Metz
6 years, 2 months ago (2018-02-18 07:22:13 UTC) #1
Joachim Metz
Code updated.
6 years, 2 months ago (2018-02-18 07:35:26 UTC) #2
onager
https://codereview.appspot.com/334500043/diff/20001/dfvfs/vfs/file_entry.py File dfvfs/vfs/file_entry.py (right): https://codereview.appspot.com/334500043/diff/20001/dfvfs/vfs/file_entry.py#newcode91 dfvfs/vfs/file_entry.py:91: entry_type (str): file entry type, such as device, directory, ...
6 years, 2 months ago (2018-02-19 15:09:13 UTC) #3
Joachim Metz
https://codereview.appspot.com/334500043/diff/20001/dfvfs/vfs/file_entry.py File dfvfs/vfs/file_entry.py (right): https://codereview.appspot.com/334500043/diff/20001/dfvfs/vfs/file_entry.py#newcode91 dfvfs/vfs/file_entry.py:91: entry_type (str): file entry type, such as device, directory, ...
6 years, 2 months ago (2018-02-19 15:22:46 UTC) #4
Joachim Metz
Code updated.
6 years, 2 months ago (2018-02-19 19:01:08 UTC) #5
onager
https://codereview.appspot.com/334500043/diff/40001/dfvfs/vfs/file_entry.py File dfvfs/vfs/file_entry.py (right): https://codereview.appspot.com/334500043/diff/40001/dfvfs/vfs/file_entry.py#newcode459 dfvfs/vfs/file_entry.py:459: if self._stat_object is not None: I think it's less ...
6 years, 2 months ago (2018-02-20 10:30:17 UTC) #6
onager
LGTM
6 years, 2 months ago (2018-02-20 10:30:23 UTC) #7
Joachim Metz
https://codereview.appspot.com/334500043/diff/40001/dfvfs/vfs/file_entry.py File dfvfs/vfs/file_entry.py (right): https://codereview.appspot.com/334500043/diff/40001/dfvfs/vfs/file_entry.py#newcode459 dfvfs/vfs/file_entry.py:459: if self._stat_object is not None: On 2018/02/20 10:30:17, onager ...
6 years, 2 months ago (2018-02-22 14:00:25 UTC) #8
Joachim Metz
6 years, 2 months ago (2018-02-22 14:11:58 UTC) #9 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close fetype
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b