Issue 334250043: 6EP tunnel encapsulation optimizations and code refactoring

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 334250043: 6EP tunnel encapsulation optimizations and code refactoring

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 4 months ago by armangungor

Modified:
6 years, 4 months ago

Reviewers:
safa.ismail.si, mustafa.alabaychi, dima.alissa, Alaiin

CC:
voravitt_gmail.com, robert.herjulf.olsson_gmail.com, dkostic, armangungor

Visibility:
Public.

More Reviews

Description

6EP tunnel encapsulation optimizations and code refactoring BUG=

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+218 lines, -192 lines)			Patch
M	core/net/ip/tunnel-addr.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/net/ip/tunnel-addr.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/net/tunnel/tunnel.c	View	6 chunks	+209 lines, -179 lines	0 comments	Download
M	core/net/tunnel/tunnel-ipv4-dhcp.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	examples/avr-rss2/ipv6/iot_mqtt/project-conf.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	examples/avr-rss2/ipv6/tunnel_br/project-conf.h	View	1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

armangungor

6 years, 4 months ago (2017-12-13 11:49:17 UTC) #1

Initial implementation of 6EP was proof of concept and had some quick and dirty
parts in order to get quick results to prove it will work. Some optimization and
code refactorings were necessary. 

Handling of local packets(ie DHCP) and tunnel related packets completely
isolated by this way a lot of redundant code removed efficiency of the
encap/decap functions increased significantly. memory copy operations decreased
to minimum level, memory move operations completely avoided. Code refactored to
make it more readable and compact. Now code is running stable and efficient,
ready to freeze and start evaluations.

Expand All Messages | Collapse All Messages