Simple-Network-Topology

Simple-Network-Topology

BUG=

[engr.sikandar.iqbal, 2017-11-23 14:45:40]

Please find the mid-level topology that has 9 switches and 12 hosts. Please make
comments for improvement.

[Michail.Xirouchakis, 2017-11-23 17:02:17]

On 2017/11/23 14:45:40, engr.sikandar.iqbal wrote:
> Please find the mid-level topology that has 9 switches and 12 hosts. Please
make
> comments for improvement.

Can this topology be run with an external controller? (We use Ryu)
If yes, how?

[Vasileios Papageorgiou, 2017-11-25 18:37:49]

Hi Sikandar,

I added some comments regarding your tology implementation.

BR,

Vasileios Papageorgiou

https://codereview.appspot.com/334160043/diff/1/topology/the-test-topology1.py
File topology/the-test-topology1.py (right):

https://codereview.appspot.com/334160043/diff/1/topology/the-test-topology1.p...
topology/the-test-topology1.py:2: 
from mininet.topo import Topo
#You can add this line so that you are based on Topo class of mininet

https://codereview.appspot.com/334160043/diff/1/topology/the-test-topology1.p...
topology/the-test-topology1.py:10: 
It would be possible to define class name here as well.
class MyNetwork( Topo) : for instance

https://codereview.appspot.com/334160043/diff/1/topology/the-test-topology1.p...
topology/the-test-topology1.py:19: c0=net.addController(name='c0',
Have you tried with Ryu Controller?
A good way to test would be to start a ryu-manager app with simple
switch_stp_13.py and then on another terminal run the topology.
For example: ryu-manager simple_switch_stp_13.py and then
on another terminal 
sudo mn --custom the-test-topology1.py --topo mynetwork --controller remote
--mac. In that case you would not need to have lines 19-22. This is no need it
if you look also at topo-standford-topology.py

https://codereview.appspot.com/334160043/diff/1/topology/the-test-topology1.p...
topology/the-test-topology1.py:23: )
For the implementation of switches, hosts, links looks fine but if you want to
optimize try to think for a loop so that it can be more efficient when you need
to add 50 or 100 switches and etc.

https://codereview.appspot.com/334160043/diff/1/topology/the-test-topology1.p...
topology/the-test-topology1.py:80: for controller in net.controllers:
This might not be necessary if you are using ryu- default controller.

https://codereview.appspot.com/334160043/diff/1/topology/the-test-topology1.p...
topology/the-test-topology1.py:99: if __name__ == '__main__':
Good point to have this so it can be called everywhere from other classes as
well