Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 333340043: issue 3208: MMRs for > 1 m. only count m.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 3 weeks ago by Malte Meyn
Modified:
8 months, 1 week ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

issue 3208: MMRs for > 1 m. only count m. MMRs with measure-count == 1 (single whole measure rests) don’t change their behaviour (i. e. they respect measure length when choosing the displayed rest symbol). MMRs with measure-count > 1 now only respect measure-count and don’t scale that by closest_duration_log which depends on measure-length. What do Gould et al. say about the whole issue? I don’t find the discussion on the tracker very clear

Patch Set 1 #

Patch Set 2 : use only whole rests and longer #

Patch Set 3 : add regtest #

Total comments: 1

Patch Set 4 : small whitespace correction #

Total comments: 1

Patch Set 5 : move round-up-to-longer-rest to calc_closest_duration_log and improve regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
A input/regression/multi-measure-rest-measure-length.ly View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M lily/multi-measure-rest.cc View 1 2 3 4 4 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 23
Malte Meyn
use only whole rests and longer
8 months, 3 weeks ago (2017-12-26 12:13:50 UTC) #1
Malte Meyn
On 2017/12/26 12:13:50, Malte Meyn wrote: > use only whole rests and longer If we ...
8 months, 3 weeks ago (2017-12-26 12:18:14 UTC) #2
lemzwerg
Could you provide an image?
8 months, 3 weeks ago (2017-12-26 13:41:16 UTC) #3
dan_faithful.be
On Dec 26, 2017, at 08:41, lemzwerg@googlemail.com wrote: > > Could you provide an image? ...
8 months, 3 weeks ago (2017-12-26 13:45:06 UTC) #4
Malte Meyn
On 2017/12/26 13:41:16, lemzwerg wrote: > Could you provide an image? Done at the tracker. ...
8 months, 3 weeks ago (2017-12-26 14:53:59 UTC) #5
Malte Meyn
add regtest
8 months, 3 weeks ago (2017-12-26 15:30:29 UTC) #6
mail_philholmes.net
----- Original Message ----- From: <lilypond@maltemeyn.de> To: <lemzwerg@googlemail.com>; <dan@faithful.be> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Tuesday, December ...
8 months, 3 weeks ago (2017-12-26 16:03:31 UTC) #7
lemzwerg
LGTM! https://codereview.appspot.com/333340043/diff/40001/lily/multi-measure-rest.cc File lily/multi-measure-rest.cc (right): https://codereview.appspot.com/333340043/diff/40001/lily/multi-measure-rest.cc#newcode298 lily/multi-measure-rest.cc:298: int dl = min(0 , calc_closest_duration_log (me, measure_count, ...
8 months, 3 weeks ago (2017-12-26 21:19:25 UTC) #8
Malte Meyn
small whitespace correction
8 months, 3 weeks ago (2017-12-26 21:41:26 UTC) #9
veronicalynnfierro
On 2017/12/26 21:41:26, Malte Meyn wrote: > small whitespace correction ('j')
8 months, 3 weeks ago (2017-12-27 19:56:49 UTC) #10
Dan Eble
https://codereview.appspot.com/333340043/diff/50003/input/regression/multi-measure-rest-measure-length.ly File input/regression/multi-measure-rest-measure-length.ly (right): https://codereview.appspot.com/333340043/diff/50003/input/regression/multi-measure-rest-measure-length.ly#newcode16 input/regression/multi-measure-rest-measure-length.ly:16: \override MultiMeasureRest.usable-duration-logs = #'(2 1 0 -1 -2) Seeing ...
8 months, 3 weeks ago (2017-12-27 22:52:06 UTC) #11
Malte Meyn
On 2017/12/27 22:52:06, Dan Eble wrote: > Another thing I see is that calc_closest_duration_log() also ...
8 months, 3 weeks ago (2017-12-28 10:49:17 UTC) #12
Malte Meyn
While trying to fix that the following question came to my mind: Do we really ...
8 months, 3 weeks ago (2017-12-28 11:14:18 UTC) #13
Malte Meyn
On 2017/12/28 11:14:18, Malte Meyn wrote: > While trying to fix that the following question ...
8 months, 3 weeks ago (2017-12-28 11:22:45 UTC) #14
dan_faithful.be
On Dec 28, 2017, at 05:49, lilypond@maltemeyn.de wrote: > > Thank you for that hint. ...
8 months, 3 weeks ago (2017-12-28 16:55:53 UTC) #15
Malte Meyn
On 2017/12/28 16:55:53, dan_faithful.be wrote: > I don’t consider myself qualified to answer your questions ...
8 months, 3 weeks ago (2017-12-30 11:00:26 UTC) #16
Malte Meyn
move round-up-to-longer-rest to calc_closest_duration_log and improve regtest
8 months, 3 weeks ago (2017-12-30 11:03:12 UTC) #17
Malte Meyn
On 2017/12/26 16:03:31, mail_philholmes.net wrote: > > Can anyone ask Gould about this topic? My ...
8 months, 2 weeks ago (2018-01-03 20:37:33 UTC) #18
benko.pal
On 2018/01/03 20:37:33, Malte Meyn wrote: > I think you’re right. (I found the German ...
8 months, 2 weeks ago (2018-01-04 19:48:36 UTC) #19
Malte Meyn
On 2018/01/04 19:48:36, benko.pal wrote: > is there an example where a single measure rest ...
8 months, 2 weeks ago (2018-01-06 16:48:08 UTC) #20
benko.pal
2018-01-06 17:48 GMT+01:00 <lilypond@maltemeyn.de>: > On 2018/01/04 19:48:36, benko.pal wrote: >> >> is there an ...
8 months, 2 weeks ago (2018-01-06 20:02:02 UTC) #21
aurana87
8 months, 2 weeks ago (2018-01-07 22:34:16 UTC) #22
aurana87
8 months, 1 week ago (2018-01-11 00:54:32 UTC) #23
Pada tanggal 8 Jan 2018 05:34, <aurana87@gmail.com> menulis:

> https://codereview.appspot.com/333340043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b