Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1002)

Issue 3333042: gettext docs improvements (take 1)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by merwok
Modified:
9 years, 9 months ago
Reviewers:
Georg
Base URL:
http://svn.python.org/projects/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -66 lines) Patch
M Doc/library/gettext.rst View 19 chunks +69 lines, -66 lines 2 comments Download

Messages

Total messages: 2
Georg
Looks good, see one inline comment. Don't hesitate to rewrap to 80 chars; if the ...
9 years, 10 months ago (2010-11-26 11:47:48 UTC) #1
merwok
9 years, 9 months ago (2010-11-26 23:41:26 UTC) #2
Thanks for the review.  I’ll commit as is next week if there are no further
comments (especially from Barry).

> Don't hesitate to rewrap to 80 chars; if the patch is
> going to be applied to all maintained branches, merging is
> not a concern.

Yes, it’s intended for all three branches.  The rationale for not rewrapping was
not merging but avoiding noise in the diff itself.

http://codereview.appspot.com/3333042/diff/1/Doc/library/gettext.rst
File Doc/library/gettext.rst (right):

http://codereview.appspot.com/3333042/diff/1/Doc/library/gettext.rst#newcode171
Doc/library/gettext.rst:171: Return a :class:`*Translations` instance based on
the *domain*, *localedir*,
There is no Translation or Translations class, but NullTranslations,
GNUTranslations and user-defined classes.  The asterisk is my attempt to convey
that, but I’m not sure it’s clear enough.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b