Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(565)

Issue 333110043: [plaso] Correctly encode product version in session (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by onager
Modified:
6 days, 21 hours ago
Reviewers:
Joachim Metz, aaronp
CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Correctly encode product version in session

Patch Set 1 #

Patch Set 2 : Switched to specify version as unicode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M plaso/__init__.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
onager
1 week ago (2017-11-14 13:25:25 UTC) #1
aaronp
LGTM
1 week ago (2017-11-14 15:35:23 UTC) #2
onager
Code updated.
1 week ago (2017-11-15 10:42:26 UTC) #3
Joachim Metz
per conversation, LGTM on updated CL
6 days, 22 hours ago (2017-11-15 14:50:38 UTC) #4
onager
6 days, 21 hours ago (2017-11-15 14:57:32 UTC) #5
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close decode_version
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4