Issue 332930043: send/receive UDP message from sensor node (IPv6) to an Internet host (IPv4) and vice versa

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 332930043: send/receive UDP message from sensor node (IPv6) to an Internet host (IPv4) and vice versa

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by armangungor

Modified:
6 years, 6 months ago

Reviewers:
safa.ismail.si, mustafa.alabaychi, dkostic, dima.alissa, Alaiin

CC:
iotik2200ht17_ict.kth.se

Visibility:
Public.

More Reviews

Description

send/receive UDP message from sensor node (IPv6) to an Internet host (IPv4) and vice versa BUG=

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -27 lines)			Patch
A	udp-client/README.md	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	udp-client/project-conf.h	View	1 chunk	+9 lines, -0 lines	1 comment	Download
M	udp-client/udp-client.c	View	3 chunks	+6 lines, -27 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

armangungor

Please review the udp-client, description is available in readme file.

6 years, 6 months ago (2017-10-17 22:44:26 UTC) #1

safa.ismail.SI

I see that the code is fine. just wanted to remind about the variables that ...

6 years, 6 months ago (2017-10-18 09:47:17 UTC) #2

dima.alissa

6 years, 6 months ago (2017-10-19 12:18:36 UTC) #3

I tried to run the code on cooja it works correctly Please check my my comment

https://codereview.appspot.com/332930043/diff/1/udp-client/udp-client.c
File udp-client/udp-client.c (right):

https://codereview.appspot.com/332930043/diff/1/udp-client/udp-client.c#newco...
udp-client/udp-client.c:148: uip_ip6addr(&server_ipaddr, 0x0000, 0, 0, 0, 0,
0xffff, 0xc0a8, 0x0197); //192.168.1.151 host address
I suggest that we change the code so that we pass these variables as arguments
before compiling the code , so we do not need to change the code every time we
add new sensor node

Expand All Messages | Collapse All Messages