Issue 332610043: Stop wifi transmissions and receptions when energy is depleted

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 3 months ago by S. Deronne

Modified:
6 years, 3 months ago

Reviewers:
Rediet

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

More Reviews

Description

Stop wifi transmissions and receptions when energy is depleted

Patch Set 1 : First proposal #

Total comments: 6

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+276 lines, -51 lines)			Patch
M	src/energy/model/basic-energy-source.cc	View	3 chunks	+10 lines, -14 lines	0 comments	Download
M	src/energy/model/device-energy-model.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/energy/model/energy-source.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/energy/model/energy-source.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/energy/model/simple-device-energy-model.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/uan/model/acoustic-modem-energy-model.h	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/uan/model/acoustic-modem-energy-model.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/wifi/helper/wifi-radio-energy-model-helper.cc	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	src/wifi/model/mac-low.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/wifi/model/wifi-phy.h	View	4 chunks	+29 lines, -7 lines	0 comments	Download
M	src/wifi/model/wifi-phy.cc	View	8 chunks	+69 lines, -9 lines	4 comments	Download
M	src/wifi/model/wifi-phy-tag.h	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	src/wifi/model/wifi-phy-tag.cc	View	4 chunks	+13 lines, -4 lines	0 comments	Download
M	src/wifi/model/wifi-radio-energy-model.h	View	3 chunks	+16 lines, -0 lines	0 comments	Download
M	src/wifi/model/wifi-radio-energy-model.cc	View	6 chunks	+64 lines, -1 line	2 comments	Download
M	src/wifi/test/spectrum-wifi-phy-test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Rediet

Hello Sébastien, You'll find a few comments/questions below. Rediet https://codereview.appspot.com/332610043/diff/1/src/wifi/model/wifi-phy.cc File src/wifi/model/wifi-phy.cc (right): https://codereview.appspot.com/332610043/diff/1/src/wifi/model/wifi-phy.cc#newcode731 src/wifi/model/wifi-phy.cc:731: ...

6 years, 3 months ago (2018-01-11 08:34:34 UTC) #1

S. Deronne

6 years, 3 months ago (2018-01-13 16:03:01 UTC) #2

Rediet, thanks for your comments, please check answers inline.

https://codereview.appspot.com/332610043/diff/1/src/wifi/model/wifi-phy.cc
File src/wifi/model/wifi-phy.cc (right):

https://codereview.appspot.com/332610043/diff/1/src/wifi/model/wifi-phy.cc#ne...
src/wifi/model/wifi-phy.cc:731: }
On 2018/01/11 08:34:34, Rediet wrote:
> Wouldn't it be more practical to set up an attribute enabling to set this
model?

Wifi can only be used with that model, so I see only two possibilities: no
energy model or the wifi radio energy model.

https://codereview.appspot.com/332610043/diff/1/src/wifi/model/wifi-phy.cc#ne...
src/wifi/model/wifi-phy.cc:2381: }
Agreed, I think it can come at the same point as this check:  if
(m_state->IsStateSleep ())

https://codereview.appspot.com/332610043/diff/1/src/wifi/model/wifi-radio-ene...
File src/wifi/model/wifi-radio-energy-model.cc (right):

https://codereview.appspot.com/332610043/diff/1/src/wifi/model/wifi-radio-ene...
src/wifi/model/wifi-radio-energy-model.cc:285: NS_FATAL_ERROR
("WifiRadioEnergyModel: undefined radio state " << state);
Yes, we cannot return an infinite time.

Expand All Messages | Collapse All Messages