Issue 33240044: code review 33240044: fix gcc 4.8 warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 33240044: code review 33240044: fix gcc 4.8 warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by 0intro

Modified:
10 years, 9 months ago

Reviewers:
rsc

CC:
rsc

Visibility:
Public.

Description

fix gcc 4.8 warnings

Patch Set 1 #

Patch Set 2 : diff -r d75b433706b7 http://code.google.com/p/plan9port #

Patch Set 3 : diff -r 1fb6abf068d2 https://code.google.com/p/plan9port/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -15 lines)			Patch
src/cmd/devdraw/x11-draw.c	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
src/cmd/fontsrv/x11.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
src/cmd/join.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
src/cmd/postscript/tr2post/utils.c	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
src/cmd/rio/showevent/ShowEvent.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
src/libventi/file.c	View	1	6 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello rsc, I'd like you to review this change to http://code.google.com/p/plan9port

11 years ago (2013-11-26 19:56:38 UTC) #1

0intro

10 years, 9 months ago (2014-03-03 21:31:09 UTC) #4

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=0c036a6d4d22 ***

fix gcc 4.8 warnings

LGTM=rsc
R=rsc
https://codereview.appspot.com/33240044

Expand All Messages | Collapse All Messages