Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(614)

Issue 33230043: Use a random service name for tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by benji
Modified:
6 years, 3 months ago
Reviewers:
bac, mp+196775
Visibility:
Public.

Description

Use a random service name for tests. This branch also changes the retry decorator to reraise the first exception it receives instead of the last. https://code.launchpad.net/~benji/charms/precise/juju-gui/test-failure/+merge/196775 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Use a random service name for tests. #

Patch Set 3 : Use a random service name for tests. #

Total comments: 14

Patch Set 4 : Use a random service name for tests. #

Patch Set 5 : Use a random service name for tests. #

Patch Set 6 : Use a random service name for tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M .bzrignore View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A [revision details] View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M test-requirements.pip View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
benji
Here are some comments for the reviewer. https://codereview.appspot.com/33230043/diff/40001/tests/20-functional.test File tests/20-functional.test (right): https://codereview.appspot.com/33230043/diff/40001/tests/20-functional.test#newcode148 tests/20-functional.test:148: unit_info, self.service_name ...
6 years, 4 months ago (2013-11-26 20:21:31 UTC) #1
bac
nice. LGTM. splendid. https://codereview.appspot.com/33230043/diff/40001/tests/20-functional.test File tests/20-functional.test (left): https://codereview.appspot.com/33230043/diff/40001/tests/20-functional.test#oldcode169 tests/20-functional.test:169: juju_destroy_service(self.charm) That clearly looked silly before. ...
6 years, 4 months ago (2013-11-26 20:35:46 UTC) #2
benji
Docstringitization and hypheneting complete. https://codereview.appspot.com/33230043/diff/40001/tests/test_deploy.py File tests/test_deploy.py (right): https://codereview.appspot.com/33230043/diff/40001/tests/test_deploy.py#newcode35 tests/test_deploy.py:35: def contains(needle, haystack): On 2013/11/26 ...
6 years, 4 months ago (2013-11-26 20:42:40 UTC) #3
benji
Please take a look.
6 years, 4 months ago (2013-11-26 20:44:06 UTC) #4
benji
*** Submitted: Use a random service name for tests. This branch also changes the retry ...
6 years, 4 months ago (2013-11-26 20:47:49 UTC) #5
benji
6 years, 3 months ago (2014-01-09 13:53:20 UTC) #6
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b