Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1655)

Issue 331760043: LoRaWAN module review request

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by Davide Magrin
Modified:
4 years, 7 months ago
Reviewers:
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This ns-3 module allows the simulation of a LoRaWAN network. Github repo: https://github.com/DvdMgr/lorawan

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17954 lines, -12 lines) Patch
M doc/models/Makefile View 9 chunks +11 lines, -10 lines 0 comments Download
M doc/models/source/index.rst View 2 chunks +3 lines, -2 lines 0 comments Download
A src/lorawan/doc/figures/LoRaWANTopology.pdf View Binary file 0 comments Download
A src/lorawan/doc/lorawan.rst View 1 chunk +538 lines, -0 lines 0 comments Download
A src/lorawan/examples/channel-test.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A src/lorawan/examples/complete-lorawan-network-example.cc View 1 chunk +494 lines, -0 lines 0 comments Download
A src/lorawan/examples/endDevices.png View Binary file 0 comments Download
A src/lorawan/examples/header-test.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A src/lorawan/examples/lora-mac-test.cc View 1 chunk +766 lines, -0 lines 0 comments Download
A src/lorawan/examples/network-server-example.cc View 1 chunk +176 lines, -0 lines 0 comments Download
A src/lorawan/examples/phy-communication-test.cc View 1 chunk +274 lines, -0 lines 0 comments Download
A src/lorawan/examples/plot-end-devices.gnuplot View 1 chunk +28 lines, -0 lines 0 comments Download
A src/lorawan/examples/receive-path-test.cc View 1 chunk +336 lines, -0 lines 0 comments Download
A src/lorawan/examples/simple-lorawan-network-example.cc View 1 chunk +145 lines, -0 lines 0 comments Download
A src/lorawan/examples/time-on-air-test.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A src/lorawan/examples/wscript View 1 chunk +29 lines, -0 lines 0 comments Download
A src/lorawan/helper/forwarder-helper.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/lorawan/helper/forwarder-helper.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A src/lorawan/helper/lora-helper.h View 1 chunk +75 lines, -0 lines 0 comments Download
A src/lorawan/helper/lora-helper.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A src/lorawan/helper/lora-mac-helper.h View 1 chunk +143 lines, -0 lines 0 comments Download
A src/lorawan/helper/lora-mac-helper.cc View 1 chunk +314 lines, -0 lines 0 comments Download
A src/lorawan/helper/lora-phy-helper.h View 1 chunk +104 lines, -0 lines 0 comments Download
A src/lorawan/helper/lora-phy-helper.cc View 1 chunk +119 lines, -0 lines 0 comments Download
A src/lorawan/helper/network-server-helper.h View 1 chunk +76 lines, -0 lines 0 comments Download
A src/lorawan/helper/network-server-helper.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A src/lorawan/helper/one-shot-sender-helper.h View 1 chunk +66 lines, -0 lines 0 comments Download
A src/lorawan/helper/one-shot-sender-helper.cc View 1 chunk +87 lines, -0 lines 0 comments Download
A src/lorawan/helper/periodic-sender-helper.h View 1 chunk +79 lines, -0 lines 0 comments Download
A src/lorawan/helper/periodic-sender-helper.cc View 1 chunk +124 lines, -0 lines 0 comments Download
A src/lorawan/model/device-status.h View 1 chunk +197 lines, -0 lines 0 comments Download
A src/lorawan/model/device-status.cc View 1 chunk +197 lines, -0 lines 0 comments Download
A src/lorawan/model/end-device-lora-mac.h View 1 chunk +435 lines, -0 lines 0 comments Download
A src/lorawan/model/end-device-lora-mac.cc View 1 chunk +902 lines, -0 lines 0 comments Download
A src/lorawan/model/end-device-lora-phy.h View 1 chunk +195 lines, -0 lines 0 comments Download
A src/lorawan/model/end-device-lora-phy.cc View 1 chunk +404 lines, -0 lines 0 comments Download
A src/lorawan/model/forwarder.h View 1 chunk +98 lines, -0 lines 0 comments Download
A src/lorawan/model/forwarder.cc View 1 chunk +112 lines, -0 lines 0 comments Download
A src/lorawan/model/gateway-lora-mac.h View 1 chunk +64 lines, -0 lines 0 comments Download
A src/lorawan/model/gateway-lora-mac.cc View 1 chunk +138 lines, -0 lines 0 comments Download
A src/lorawan/model/gateway-lora-phy.h View 1 chunk +208 lines, -0 lines 0 comments Download
A src/lorawan/model/gateway-lora-phy.cc View 1 chunk +408 lines, -0 lines 0 comments Download
A src/lorawan/model/gateway-status.h View 1 chunk +97 lines, -0 lines 0 comments Download
A src/lorawan/model/gateway-status.cc View 1 chunk +120 lines, -0 lines 0 comments Download
A src/lorawan/model/logical-lora-channel.h View 1 chunk +144 lines, -0 lines 0 comments Download
A src/lorawan/model/logical-lora-channel.cc View 1 chunk +134 lines, -0 lines 0 comments Download
A src/lorawan/model/logical-lora-channel-helper.h View 1 chunk +195 lines, -0 lines 0 comments Download
A src/lorawan/model/logical-lora-channel-helper.cc View 1 chunk +250 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-channel.h View 1 chunk +198 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-channel.cc View 1 chunk +207 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-device-address.h View 1 chunk +222 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-device-address.cc View 1 chunk +268 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-device-address-generator.h View 1 chunk +89 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-device-address-generator.cc View 1 chunk +76 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-frame-header.h View 1 chunk +343 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-frame-header.cc View 1 chunk +594 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-interference-helper.h View 1 chunk +232 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-interference-helper.cc View 1 chunk +409 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-mac.h View 1 chunk +269 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-mac.cc View 1 chunk +181 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-mac-header.h View 1 chunk +134 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-mac-header.cc View 1 chunk +152 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-net-device.h View 1 chunk +162 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-net-device.cc View 1 chunk +330 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-phy.h View 1 chunk +306 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-phy.cc View 1 chunk +210 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-tag.h View 1 chunk +134 lines, -0 lines 0 comments Download
A src/lorawan/model/lora-tag.cc View 1 chunk +154 lines, -0 lines 0 comments Download
A src/lorawan/model/mac-command.h View 1 chunk +618 lines, -0 lines 0 comments Download
A src/lorawan/model/mac-command.cc View 1 chunk +1222 lines, -0 lines 0 comments Download
A src/lorawan/model/one-shot-sender.h View 1 chunk +80 lines, -0 lines 0 comments Download
A src/lorawan/model/one-shot-sender.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A src/lorawan/model/periodic-sender.h View 1 chunk +106 lines, -0 lines 0 comments Download
A src/lorawan/model/periodic-sender.cc View 1 chunk +143 lines, -0 lines 0 comments Download
A src/lorawan/model/simple-network-server.h View 1 chunk +126 lines, -0 lines 0 comments Download
A src/lorawan/model/simple-network-server.cc View 1 chunk +321 lines, -0 lines 0 comments Download
A src/lorawan/model/sub-band.h View 1 chunk +139 lines, -0 lines 0 comments Download
A src/lorawan/model/sub-band.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A src/lorawan/test/lorawan-test-suite.cc View 1 chunk +1316 lines, -0 lines 0 comments Download
A src/lorawan/wscript View 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Davide Magrin
4 years, 7 months ago (2017-09-30 16:33:26 UTC) #1
Hello everyone,
I'm Davide Magrin, a PhD student at the University of Padova. I wrote the module
contained in this issue during my master's thesis, with the objective of
simulating a LoRaWAN network in ns-3. Now that it has reached a sufficient level
of complexity, we would like to share it and ask for the community's feedback.

This issue, besides the module code, also contains adjustments to the
documentation makefile, so that you can compile the src/lorawan/doc/lorawan.rst
correctly and view the module description in a browser. The .rst file contains a
description of the module, its current state of completion and its limitations,
referencing the relevant papers and datasheets that guided the design.  

Since this issue on rietveld was mainly created to have feedback on code, I'll
also be starting a thread on the ns-developers mailing list in order to discuss
more high-level design issues (like the implementation of a possibly very
complex Network Server, or the choices I've made in the MAC layer design). You
are welcome to share your thoughts on the channel you deem the most appropriate.

A public repository containing the full module can also be found at
https://github.com/DvdMgr/lorawan. I'll monitor that repository for issue
tracking and (hopefully) future contributions by the community via pull
requests.

Thank you!

-- Davide
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b