Adds relation status to inspector relation panel

Adds relation status to inspector relation panel

The overall relation status is now indicated on the inspector relation
panel using the same icons as the unit status. If any unit has a relation
error the entire relation is shown as in error.

https://code.launchpad.net/~hatch/juju-gui/inspector-relation-status/+merge/196770

(do not edit description out of merge proposal)

[jeff.pihach, 2013-11-26 18:45:21]

Please take a look.

[jeff.pihach, 2013-11-26 18:47:29]

reviewer notes

https://codereview.appspot.com/33130043/diff/1/app/templates/service-relation...
File app/templates/service-relations.handlebars (left):

https://codereview.appspot.com/33130043/diff/1/app/templates/service-relation...
app/templates/service-relations.handlebars:1: {{> service-header}}
Template from old inspector

[jeff.pihach, 2013-11-26 20:39:34]

Please take a look.

[jeff.pihach, 2013-11-26 20:42:44]

reviewer notes v2

https://codereview.appspot.com/33130043/diff/20001/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/33130043/diff/20001/app/models/models.js#newco...
app/models/models.js:605: if (state === 'error') {
Fix for bug from first rev (see test_model)

https://codereview.appspot.com/33130043/diff/20001/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/33130043/diff/20001/test/test_model.js#newcode136
test/test_model.js:136: id: 'wordpress/2',
The order of these is important to make sure that the first unit error, if it's
a relation error gets caught properly (bug from first rev)

[gary.poster, 2013-11-26 21:53:45]

LGTM with trivials and sandbox QA good.  waiting on QA on ec2.

https://codereview.appspot.com/33130043/diff/20001/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/33130043/diff/20001/app/models/models.js#newco...
app/models/models.js:591: @return {Array} An array of the aggregate map and
relation errors
Thank you for improving names and docs.  Nice.

https://codereview.appspot.com/33130043/diff/20001/app/models/models.js#newco...
app/models/models.js:614: if (farService) {
this code fixes peer relation issues?

https://codereview.appspot.com/33130043/diff/20001/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/33130043/diff/20001/test/test_model.js#newcode136
test/test_model.js:136: id: 'wordpress/2',
On 2013/11/26 20:42:45, jeff.pihach wrote:
> The order of these is important to make sure that the first unit error, if
it's
> a relation error gets caught properly (bug from first rev)

In that case could you elaborate in a code comment what's going on?  All I see
in the code is "one of these has a relation error and one has an install error,"
not something subtle about ordering.

[gary.poster, 2013-11-26 22:18:24]

QA OK on real environment also.  Thanks!  These are really cool changes you are
making.

[jeff.pihach, 2013-11-26 22:22:40]

Thanks for the review! Changes landing

https://codereview.appspot.com/33130043/diff/20001/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/33130043/diff/20001/test/test_model.js#newcode136
test/test_model.js:136: id: 'wordpress/2',
good call, done

[jeff.pihach, 2013-11-26 22:36:20]

*** Submitted:

Adds relation status to inspector relation panel

The overall relation status is now indicated on the inspector relation
panel using the same icons as the unit status. If any unit has a relation
error the entire relation is shown as in error.

R=gary.poster
CC=
https://codereview.appspot.com/33130043