Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4285)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 331070043: [IoT CodeReview] minor fixes for 2-way udp application

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by armangungor
Modified:
6 years, 5 months ago
Reviewers:
robert, dkostic, mustafa.alabaychi, robert.herjulf.olsson, voravitt, Alaiin, dima.alissa, safa.ismail.si
Visibility:
Public.

Description

minor fixes for 2-way udp application BUG=global ipv6 prefix was invalid, fixed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M iot_lab/avr-rss2/ipv6/iot_br/Makefile View 2 chunks +2 lines, -0 lines 0 comments Download
M iot_lab/avr-rss2/ipv6/iot_br/border-router.c View 2 chunks +2 lines, -3 lines 0 comments Download
A iot_lab/avr-rss2/ipv6/iot_br/contiki-avr-rss2.a View Binary file 0 comments Download
M iot_lab/avr-rss2/ipv6/iot_br/eth-bridge.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
armangungor
Global IPv6 prefix was invalid, fixed. Now a host can reply back to a UDP ...
6 years, 6 months ago (2017-10-22 20:59:34 UTC) #1
robert_herjulf.se
armangungor@gmail.com writes: > Reviewers: dima.alissa, safa.ismail.si_gmail.com, Alaiin, > mustafa.alabaychi, dkostic, > > Message: > Global ...
6 years, 6 months ago (2017-10-24 14:16:57 UTC) #2
armangungor
Thanks for comments. Global ipv6 prefix in *iot_br(border router code) *code was not compatible with ...
6 years, 5 months ago (2017-11-06 21:45:37 UTC) #3
robert_herjulf.se
6 years, 5 months ago (2017-11-07 12:51:03 UTC) #4 

Oki,

Thinking about our last meeting. You wanted to have the NAT translation 
among the IEP functions. We proposed an existing boarder router both 
and HW with where NAT translations was on the 6EP side.  I still this 
a usable? HW should be fina at least. Have you done some analysis here?


  	     	       	       	     --ro


Arman Güngör writes:
 > Thanks for comments.
 > 
 > Global ipv6 prefix in *iot_br(border router code) *code was not compatible
 > with the rest of the components. Instead of 'UIP_DS6_DEFAULT_PREFIX', it
 > was using custom prefix '0xfd02'. This was in iot_br code. There is no
 > problem in Contiki's IP64 core.
 > 
 > On Tue, Oct 24, 2017 at 4:16 PM, Robert Olsson <robert@herjulf.se> wrote:
 > 
 > >
 > > armangungor@gmail.com writes:
 > >  > Reviewers: dima.alissa, safa.ismail.si_gmail.com, Alaiin,
 > >  > mustafa.alabaychi, dkostic,
 > >  >
 > >  > Message:
 > >  > Global IPv6 prefix was invalid, fixed. Now a host can reply back to a
 > >  > UDP packet. NAT64 is working completely.
 > >
 > >  Excellent.
 > >
 > >  > Description:
 > >  > minor fixes for 2-way udp application
 > >  >
 > >  > BUG=global ipv6 prefix was invalid, fixed
 > >
 > >  Can you please expand this a bit.
 > >  An address prefix issue or routing  issue?
 > >
 > >  Meaning a patch Contiki's IP64 core is also needed?
 > >
 > >                            --ro
 > >
 > >
 > >  > Please review this at https://codereview.appspot.com/331070043/
 > >  >
 > >  > Affected files (+4, -3 lines):
 > >  >    M iot_lab/avr-rss2/ipv6/iot_br/Makefile
 > >  >    M iot_lab/avr-rss2/ipv6/iot_br/border-router.c
 > >  >    A iot_lab/avr-rss2/ipv6/iot_br/contiki-avr-rss2.a
 > >  >    M iot_lab/avr-rss2/ipv6/iot_br/eth-bridge.c
 > >  >
 > >  >
 > >  > Index: iot_lab/avr-rss2/ipv6/iot_br/Makefile
 > >  > diff --git a/iot_lab/avr-rss2/ipv6/iot_br/Makefile
 > >  > b/iot_lab/avr-rss2/ipv6/iot_br/Makefile
 > >  > index
 > >  > e416486e6428f503162b42c80bb117da86212200..
 > > 37bdd13b07f59dac492e0a4beca3efaea2c8ab6b
 > >  > 100644
 > >  > --- a/iot_lab/avr-rss2/ipv6/iot_br/Makefile
 > >  > +++ b/iot_lab/avr-rss2/ipv6/iot_br/Makefile
 > >  > @@ -10,6 +10,7 @@ CFLAGS += -DPROJECT_CONF_H=\"project-conf.h\"
 > >  >   PROJECT_SOURCEFILES += eth-bridge.c
 > >  >   #PROJECT_SOURCEFILES += enc28j60.c
 > >  >   PROJECT_SOURCEFILES += enc28j60-ip64-driver.c
 > >  > +#PROJECT_SOURCEFILES += commands.c #ARMAN
 > >  >
 > >  >   APPS += ping6
 > >  >   APPS += cli
 > >  > @@ -32,6 +33,7 @@ WITH_WEBSERVER=1
 > >  >   ifeq ($(WITH_WEBSERVER),1)
 > >  >   CFLAGS += -DUIP_CONF_TCP=1
 > >  >   CFLAGS += -DWEBSERVER=1
 > >  > +CFLAGS += -DDEBUG=2 #ARMAN
 > >  >   PROJECT_SOURCEFILES += httpd-simple.c
 > >  >   PROJECT_SOURCEFILES += commands.c #AG: does not compile without this
 > >  >   else ifneq ($(WITH_WEBSERVER), 0)
 > >  > Index: iot_lab/avr-rss2/ipv6/iot_br/border-router.c
 > >  > diff --git a/iot_lab/avr-rss2/ipv6/iot_br/border-router.c
 > >  > b/iot_lab/avr-rss2/ipv6/iot_br/border-router.c
 > >  > index
 > >  > 7118edd1185baec2b4f8164a1dcffb0456211b2b..
 > > 861c2991fe5d93c6849f083539e9fed987ec894d
 > >  > 100644
 > >  > --- a/iot_lab/avr-rss2/ipv6/iot_br/border-router.c
 > >  > +++ b/iot_lab/avr-rss2/ipv6/iot_br/border-router.c
 > >  > @@ -55,7 +55,7 @@
 > >  >   #include <string.h>
 > >  >   #include <ctype.h>
 > >  >
 > >  > -#define DEBUG DEBUG_PRINT
 > >  > +#define DEBUG DEBUG_FULL
 > >  >   #include "net/ip/uip-debug.h"
 > >  >
 > >  >   static uip_ipaddr_t prefix;
 > >  > @@ -375,8 +375,7 @@ PROCESS_THREAD(border_router_process, ev, data)
 > >  >     NETSTACK_MAC.off(1);
 > >  >
 > >  >   /* Derived from link local (MAC) address */
 > >  > -  //uip_ip6addr(&ipaddr, UIP_DS6_DEFAULT_PREFIX, 0, 0, 0, 0, 0, 0, 0);
 > >  > -  uip_ip6addr(&ipaddr, 0xfd02, 0, 0, 0, 0, 0, 0, 0);
 > >  > +  uip_ip6addr(&ipaddr, UIP_DS6_DEFAULT_PREFIX, 0, 0, 0, 0, 0, 0, 0);
 > >  >     set_prefix_64(&ipaddr);
 > >  >     print_local_addresses();
 > >  >
 > >  > Index: iot_lab/avr-rss2/ipv6/iot_br/contiki-avr-rss2.a
 > >  > diff --git a/iot_lab/avr-rss2/ipv6/iot_br/contiki-avr-rss2.a
 > >  > b/iot_lab/avr-rss2/ipv6/iot_br/contiki-avr-rss2.a
 > >  > new file mode 100644
 > >  > index
 > >  > 0000000000000000000000000000000000000000..
 > > 6bd19b5f7bf2ad261ad13cd201ff7c986d134402
 > >  > Binary files /dev/null and
 > >  > b/iot_lab/avr-rss2/ipv6/iot_br/contiki-avr-rss2.a differ
 > >  > Index: iot_lab/avr-rss2/ipv6/iot_br/eth-bridge.c
 > >  > diff --git a/iot_lab/avr-rss2/ipv6/iot_br/eth-bridge.c
 > >  > b/iot_lab/avr-rss2/ipv6/iot_br/eth-bridge.c
 > >  > index
 > >  > b5d9ec49835f47d620072c455caf88921adeed2f..
 > > 179575b0988d1dde82049568160a20ae31e3cde3
 > >  > 100644
 > >  > --- a/iot_lab/avr-rss2/ipv6/iot_br/eth-bridge.c
 > >  > +++ b/iot_lab/avr-rss2/ipv6/iot_br/eth-bridge.c
 > >  > @@ -5,7 +5,7 @@
 > >  >
 > >  >   #define UIP_IP_BUF        ((struct uip_ip_hdr
*)&uip_buf[UIP_LLH_LEN])
 > >  >
 > >  > -#define DEBUG DEBUG_NONE
 > >  > +#define DEBUG DEBUG_FULL
 > >  >   #include "net/ip/uip-debug.h"
 > >  >
 > >  >   static void
 > >  >
 > >  >
 > >
 > > --
 > >

--
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b