Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2036)

Issue 330580043: IPv4/IPv6 translation prefix expected in form ::ffff:1234:5678 instead of 0064:ff9b::1234:5678

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by armangungor
Modified:
6 years, 6 months ago
Reviewers:
safa.ismail.si, mustafa.alabaychi, dkostic, dima.alissa, Alaiin
CC:
iotik2200ht17_ict.kth.se
Visibility:
Public.

Description

IPv4/IPv6 translation prefix expected in form ::ffff:1234:5678 instead of 0064:ff9b::1234:5678 remove hardcoded broker_ip address (read from project-conf.h) BUG=

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M iot_lab/avr-rss2/ipv6/iot_mqtt/mqtt-demo.c View 1 chunk +1 line, -1 line 2 comments Download
M iot_lab/avr-rss2/ipv6/iot_mqtt/project-conf.h View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4
armangungor
In last session we used IPv4 translated IPv6 address in 0064:ff9b::1234:5678 format because of the ...
6 years, 6 months ago (2017-10-15 20:53:40 UTC) #1
dima.alissa
On 2017/10/15 20:53:40, armangungor wrote: > In last session we used IPv4 translated IPv6 address ...
6 years, 6 months ago (2017-10-16 10:29:01 UTC) #2
safa.ismail.SI
Please check my comments on the code regarding the "MQTT_DEMO_BROKER_IP_ADDR" variable Regards, Safa https://codereview.appspot.com/330580043/diff/1/iot_lab/avr-rss2/ipv6/iot_mqtt/mqtt-demo.c File ...
6 years, 6 months ago (2017-10-18 09:30:47 UTC) #3
safa.ismail.SI
6 years, 6 months ago (2017-10-18 09:33:46 UTC) #4
kindly find my comments on the conf.h file.

Regards,
Safa

https://codereview.appspot.com/330580043/diff/1/iot_lab/avr-rss2/ipv6/iot_mqt...
File iot_lab/avr-rss2/ipv6/iot_mqtt/project-conf.h (right):

https://codereview.appspot.com/330580043/diff/1/iot_lab/avr-rss2/ipv6/iot_mqt...
iot_lab/avr-rss2/ipv6/iot_mqtt/project-conf.h:60: #define BOARD_STRING 
"NODE_8263"
It is clear that there is a change in the address format.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b