Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 330530043: Added latency change execution stopper

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by david.tomic11
Modified:
1 month, 4 weeks ago
Reviewers:
tonythomas
CC:
dkostic, kirill.sc, seregibenjamin, cynthiamao122_gmail.com, liangzijie1437_gmail.com
Visibility:
Public.

Description

Added latency change execution stopper Adding infinite latency change execution Change frequency of latency changes and run experiments BUG=Run frequency changes in background while experiments execute

Patch Set 1 #

Patch Set 2 : Fixed bugs #

Total comments: 3

Patch Set 3 : Adjusting to new plotting technique #

Total comments: 1

Patch Set 4 : One line change #

Total comments: 1

Patch Set 5 : Name change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -73 lines) Patch
M api.py View 1 2 3 4 5 chunks +17 lines, -3 lines 0 comments Download
M experiments/setups/1x3.2cores.vanilla.json View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M launch_lx3.py View 1 2 6 chunks +54 lines, -13 lines 0 comments Download
D utils/ycsb_data_generate_plots.py View 1 2 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 7
tonythomas
Comments inline. Threads() looks scary, but I am sure it would work. Will need minor ...
1 month, 4 weeks ago (2017-10-14 10:03:08 UTC) #1
david.tomic11
Check out the new patch for sleep-time
1 month, 4 weeks ago (2017-10-14 16:41:39 UTC) #2
tonythomas
minor comments, and it looks nice. https://codereview.appspot.com/330530043/diff/40001/api.py File api.py (right): https://codereview.appspot.com/330530043/diff/40001/api.py#newcode82 api.py:82: if i == ...
1 month, 4 weeks ago (2017-10-14 16:49:07 UTC) #3
david.tomic11
On 2017/10/14 16:49:07, tonythomas wrote: > minor comments, and it looks nice. > > https://codereview.appspot.com/330530043/diff/40001/api.py ...
1 month, 4 weeks ago (2017-10-14 16:51:26 UTC) #4
david.tomic11
On 2017/10/14 16:51:26, david.tomic11 wrote: > On 2017/10/14 16:49:07, tonythomas wrote: > > minor comments, ...
1 month, 4 weeks ago (2017-10-14 17:40:22 UTC) #5
tonythomas
LGTM. minor thing which may/may not be included in this commit. https://codereview.appspot.com/330530043/diff/60001/api.py File api.py (right): ...
1 month, 4 weeks ago (2017-10-14 17:51:24 UTC) #6
david.tomic11
1 month, 4 weeks ago (2017-10-14 18:38:09 UTC) #7
On 2017/10/14 17:51:24, tonythomas wrote:
> LGTM. minor thing which may/may not be included in this commit.
> 
> https://codereview.appspot.com/330530043/diff/60001/api.py
> File api.py (right):
> 
> https://codereview.appspot.com/330530043/diff/60001/api.py#newcode122
> api.py:122: execution = False
> man - sorry for not telling this before - but can we make this global variable
> more meaningful ? Like what execution is it saying as False ? We might need
that
> for later ? Else, it looks nice.

Alright updated!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d