Added latency change execution stopper

Added latency change execution stopper


Adding infinite latency change execution


Change frequency of latency changes and run experiments

BUG=Run frequency changes in background while experiments execute

[tonythomas, 2017-10-14 10:03:08]

Comments inline. 

Threads() looks scary, but I am sure it would work. Will need minor changes to
make plots correctly once https://gits-15.sys.kth.se/REP/lx3/pull/17 is merged.

https://codereview.appspot.com/330530043/diff/20001/api.py
File api.py (right):

https://codereview.appspot.com/330530043/diff/20001/api.py#newcode80
api.py:80: if i == numhosts: i = 0
i=0 if i == numhosts else i
https://stackoverflow.com/questions/2802726/putting-a-simple-if-then-statemen...

https://codereview.appspot.com/330530043/diff/20001/launch_lx3.py
File launch_lx3.py (right):

https://codereview.appspot.com/330530043/diff/20001/launch_lx3.py#newcode129
launch_lx3.py:129: thread = Thread(target=api.execute_update_latencies,
args=(FLAGS, conf, net, sleep_time))
also - when doing this - can you add an extra flag variable which would be like
notify_cassandra = False ? 

As the execute_udpate_latencies for some reason do keep on notifying cassandra -
which is not required at this operation.

https://codereview.appspot.com/330530043/diff/20001/launch_lx3.py#newcode147
launch_lx3.py:147: )
for this patch to get working - we should use this new feature in my branch
whcih can actually do the right plotting. Probably you can change that once my
PR https://gits-15.sys.kth.se/REP/lx3/pull/17 gets in.

[david.tomic11, 2017-10-14 16:41:39]

Check out the new patch for sleep-time

[tonythomas, 2017-10-14 16:49:07]

minor comments, and it looks nice.

https://codereview.appspot.com/330530043/diff/40001/api.py
File api.py (right):

https://codereview.appspot.com/330530043/diff/40001/api.py#newcode82
api.py:82: if i == numhosts: i = 0
i = 0 if i == numhosts else i +1 

and remove the line above, please.

[david.tomic11, 2017-10-14 16:51:26]

On 2017/10/14 16:49:07, tonythomas wrote:
> minor comments, and it looks nice.
> 
> https://codereview.appspot.com/330530043/diff/40001/api.py
> File api.py (right):
> 
> https://codereview.appspot.com/330530043/diff/40001/api.py#newcode82
> api.py:82: if i == numhosts: i = 0
> i = 0 if i == numhosts else i +1 
> 
> and remove the line above, please.

ahahah the python freak :)

[david.tomic11, 2017-10-14 17:40:22]

On 2017/10/14 16:51:26, david.tomic11 wrote:
> On 2017/10/14 16:49:07, tonythomas wrote:
> > minor comments, and it looks nice.
> > 
> > https://codereview.appspot.com/330530043/diff/40001/api.py
> > File api.py (right):
> > 
> > https://codereview.appspot.com/330530043/diff/40001/api.py#newcode82
> > api.py:82: if i == numhosts: i = 0
> > i = 0 if i == numhosts else i +1 
> > 
> > and remove the line above, please.
> 
> ahahah the python freak :)

There we go - > check if this is ready for master

[tonythomas, 2017-10-14 17:51:24]

LGTM. minor thing which may/may not be included in this commit.

https://codereview.appspot.com/330530043/diff/60001/api.py
File api.py (right):

https://codereview.appspot.com/330530043/diff/60001/api.py#newcode122
api.py:122: execution = False
man - sorry for not telling this before - but can we make this global variable
more meaningful ? Like what execution is it saying as False ? We might need that
for later ? Else, it looks nice.

[david.tomic11, 2017-10-14 18:38:09]

On 2017/10/14 17:51:24, tonythomas wrote:
> LGTM. minor thing which may/may not be included in this commit.
> 
> https://codereview.appspot.com/330530043/diff/60001/api.py
> File api.py (right):
> 
> https://codereview.appspot.com/330530043/diff/60001/api.py#newcode122
> api.py:122: execution = False
> man - sorry for not telling this before - but can we make this global variable
> more meaningful ? Like what execution is it saying as False ? We might need
that
> for later ? Else, it looks nice.

Alright updated!